ci: add maas-controller CI workflow and remove obsolete image build from maas-api

add a dedicated github actions workflow for maas-controller that runs
lint and test jobs on PRs touching maas-controller/**, with coverage
artifact uploads. the go version and golangci-lint version are resolved
dynamically from go.mod and tools.mk respectively.

remove the image build step and push-on-merge trigger from maas-api-ci
since container builds are now handled by konflux. rename the build job
to test to reflect its actual purpose.

update maas-controller makefile test target to produce coverage output
(-race -coverprofile) consistent with the maas-api pattern.

Signed-off-by: Chaitanya Kulkarni <ckulkarn@redhat.com>
Signed-off-by: Chaitanya Kulkarni <chkulkar@redhat.com>
Made-with: Cursor

Author: chaitanya1731

.github/workflows/maas-api-ci.yml

@@ -1,9 +1,6 @@
 name: MaaS API
 
 on:
-  push:
-    branches:
-      - main
   pull_request:
     paths:
       - 'maas-api/**'
@@ -43,7 +40,7 @@ jobs:
         with:
           version: ${{ steps.golangci-version.outputs.version }}
           working-directory: ${{ env.PROJECT_DIR }}
-  build:
+  test:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
@@ -66,6 +63,3 @@ jobs:
             ${{ env.PROJECT_DIR }}/coverage.out
             ${{ env.PROJECT_DIR }}/coverage.html
           retention-days: 30
-
-      - name: Build image
-        run: make build-image

.github/workflows/maas-controller-ci.yml

@@ -0,0 +1,66 @@
+name: MaaS Controller
+
+on:
+  pull_request:
+    paths:
+      - 'maas-controller/**'
+
+permissions:
+  actions: read
+  contents: read
+
+env:
+  PROJECT_DIR: maas-controller
+
+defaults:
+
+  run:
+    working-directory: maas-controller
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+
+      - name: Align golangci-lint version with Makefile
+        id: golangci-version
+        run: |
+          VERSION=$(grep '^GOLANGCI_LINT_VERSION' tools.mk | cut -d'=' -f2 | tr -d ' ?')
+          echo "version=$VERSION" >> $GITHUB_OUTPUT
+
+      - uses: actions/setup-go@v6
+        with:
+          go-version-file: maas-controller/go.mod
+          cache: true
+          cache-dependency-path: maas-controller/go.sum
+
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v9
+        with:
+          version: ${{ steps.golangci-version.outputs.version }}
+          working-directory: ${{ env.PROJECT_DIR }}
+
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+
+      - uses: actions/setup-go@v6
+        with:
+          go-version-file: ${{ env.PROJECT_DIR }}/go.mod
+          cache: true
+          cache-dependency-path: ${{ env.PROJECT_DIR }}/go.sum
+
+      - name: Run tests
+        run: make test
+
+      - name: Upload coverage reports
+        uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: maas-controller-coverage
+          path: |
+            ${{ env.PROJECT_DIR }}/coverage.out
+            ${{ env.PROJECT_DIR }}/coverage.html
+          retention-days: 30

maas-controller/Makefile

@@ -64,9 +64,12 @@ $(BUILD_DIR):
 run: build ##	build and run manager locally
 	$(BUILD_DIR)/$(BINARY_NAME)
 
+TEST_FLAGS ?= -race -coverprofile=coverage.out
 .PHONY: test
-test: tidy ##	run tests
-	go test ./...
+test: tidy ##	run tests with coverage
+	go test $(TEST_FLAGS) ./...
+	@go tool cover -html=coverage.out -o coverage.html
+	@echo "Test coverage report generated: $(abspath coverage.html)"
 
 .PHONY: tidy
 tidy: