[Bug]: Deleting Cluster storage does not delete workbench folder

[manosnoam]

Is there an existing issue for this?

• I have searched the existing issues

Deploy type

Downstream version (eg. RHODS 1.29)

Version

1.33

Current Behavior

Deleting cluster storage does not delete the actual folder in the workbench (it only deletes the folder files and sub-folders).

Expected Behavior

The actual folder should be deleted as well, unless it is beeing used by other cluster storage resources.

Steps To Reproduce

1. Create Workbench (e.g. with TensorFlow).
2. Check that the workbench is running.
3. Add new Cluster storage with a folder (e.g. data-a).
4. Check that the workbench is running.
5. Delete that cluster storage.
6. Open the workbench, and check that the folder was deleted.

Workaround (if any)

No response

What browsers are you seeing the problem on?

Firefox, Chrome

Anything else

No response

[manosnoam]

Storages were deleted:

But folders still exist (with empty content though):

[Gkrumbach07]

cc @harshad16 not necessarily us, maybe something with stale with Jupyter lab?

[harshad16]

/transfer notebooks

[jiridanek]

Tried to reproduce, added storage

opened workbench, added some file onto it

(app-root) ls /
afs  bin  boot  cachi2  dev  etc  home  lib  lib64  media  mnt  opt  proc  root  run  sbin  somemount  srv  sys  tmp  usr  var
(app-root) touch /somemount/pepa
(app-root) ls /somemount/pepa
/somemount/pepa

clicked stop workbench, opened edit and wanted to remove storage, but first I got that workbench has been modified, and I should reload, so clicked reload, then deleted storage again, and I got

the infamous

Error creating workbench
Notebook.kubeflow.org "wbds312" is invalid: [spec.template.spec.volumes[2]: Duplicate value: map[string]interface {}{"name":"shm"}, spec.template.spec.containers[0].volumeMounts[2]: Duplicate value: map[string]interface {}{"mountPath":"/dev/shm"}]

[jiridanek]

Fix for the infamous issue is in the works by @Gkrumbach07

• Fix workbench update corruption when removing cluster storage odh-dashboard#5264

Infamous issue is tracked https://issues.redhat.com/browse/RHOAIENG-31579