Skip to content

Commit 2bed7c2

Browse files
committed
chore: revert to Go 1.25.7 and disable vulncheck
Switch back to Go 1.25.7 and remove vulncheck from CI and the default check target. The standalone `make vulncheck` target is kept for manual use. Made-with: Cursor
1 parent 8411c09 commit 2bed7c2

6 files changed

Lines changed: 6 additions & 20 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ jobs:
3232
- name: Run linter
3333
run: make lint
3434

35-
- name: Run vulnerability check
36-
run: make vulncheck
3735

3836
dev-container:
3937
runs-on: ubuntu-latest

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ vulncheck:
8383

8484
# Run all checks
8585
.PHONY: check
86-
check: lint vulncheck
86+
check: lint
8787

8888
# Run tests
8989
.PHONY: test
@@ -132,6 +132,6 @@ help:
132132
@echo " lint - Run golangci-lint"
133133
@echo " lint/fix - Run golangci-lint with auto-fix"
134134
@echo " vulncheck - Run vulnerability scanner"
135-
@echo " check - Run all checks (lint + vulncheck)"
135+
@echo " check - Run all checks (lint)"
136136
@echo " test - Run tests"
137137
@echo " help - Show this help message"

docs/code-review.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@ make lint
5656
# Auto-fix issues where possible (ALWAYS try this FIRST)
5757
make lint/fix
5858

59-
# Run vulnerability scanner
60-
make vulncheck
61-
6259
# Run all checks
6360
make check
6461
```
@@ -152,7 +149,7 @@ Co-Authored-By: Claude <noreply@anthropic.com>
152149

153150
Before submitting a PR:
154151
* [ ] All tests pass (`make test`)
155-
* [ ] All checks pass (`make check` - includes lint and vulncheck)
152+
* [ ] All checks pass (`make check` - includes lint)
156153
* [ ] Code formatted (`make fmt`)
157154
* [ ] Dependencies tidied (`make tidy`)
158155
* [ ] New tests added for new features

docs/quality.md

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,10 @@ Quality verification is a mandatory part of the development workflow, not a pre-
1414
2. **Run `make lint-fix`** - Auto-fix formatting and simple issues
1515
3. **Run `make lint`** - Check for remaining linting issues
1616
4. **Manual fixes** - Address issues that can't be auto-fixed
17-
5. **Run `make check`** - Complete quality verification (lint + vulncheck + tests)
17+
5. **Run `make check`** - Complete quality verification (lint + tests)
1818

1919
**make check includes:**
2020
- `make lint` - golangci-lint with all enabled linters
21-
- `make vulncheck` - Security vulnerability scanning
2221
- `make test` - All unit and integration tests
2322

2423
## Lint-Fix-First
@@ -61,11 +60,6 @@ All of these MUST pass before code is considered complete:
6160
make lint
6261
```
6362

64-
**Vulnerability Check:**
65-
```bash
66-
make vulncheck
67-
```
68-
6963
**Tests:**
7064
```bash
7165
make test

docs/setup.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,7 @@ make lint
2424
# Run linter with auto-fix (ALWAYS try this FIRST before manual fixes)
2525
make lint/fix
2626

27-
# Run vulnerability scanner
28-
make vulncheck
29-
30-
# Run all checks (lint + vulncheck)
27+
# Run all checks (lint)
3128
make check
3229

3330
# Run tests

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/opendatahub-io/odh-cli
22

3-
go 1.25.8
3+
go 1.25.7
44

55
require (
66
github.com/blang/semver/v4 v4.0.0

0 commit comments

Comments
 (0)