fix(e2e): wait for projects page before filtering (RHOAIENG-57594) (#7255)

* fix(e2e): wait for projects page before filtering (RHOAIENG-57594)

After visitWithLogin('/projects'), the React app may still be
initializing. Calling filterProjectByName immediately races against
the page render — if the toolbar hasn't appeared within the default
4 s command timeout, the test fails with "view not loading".

Add projectListPage.waitForPageAndToolbar() (15 s title + 30 s
toolbar) after visitWithLogin in the three tests that were missing
it, matching the pattern already used in the permissions tests.

Made-with: Cursor

* fix(e2e): bake toolbar wait into ProjectListPage.navigate() (RHOAIENG-57594)

Instead of scattering waitForPageAndToolbar() calls at every call site,
move the title+toolbar visibility guard into the private wait() method
that both navigate() and visit() already call. This ensures every
future test that uses either method gets the full render gate for free.

Also standardise the three beforeEach blocks that called
cy.visitWithLogin('/projects', USER) directly — convert them to the
canonical cy.visitWithLogin('/', USER) + projectListPage.navigate()
pattern so private wait() covers them too, and the now-redundant
waitForPageAndToolbar() public method is removed entirely.

* fix(e2e): move timeout to query command in ProjectListPage.wait()

Passing { timeout } as the second arg to .should() is silently ignored
by Cypress — for 'be.visible' assertions Chai treats it as an unused
value argument. The timeout must be on the query command so Cypress
uses it to control retry duration.

Move both timeouts from .should() to cy.findByTestId() where they
will actually take effect.

* fix(e2e): move toolbar wait into filterProjectByName (RHOAIENG-57594)

Waiting for projects-table-toolbar in private wait() broke mock tests
that exercise the empty-state path (shouldBeEmpty) — the toolbar is
never rendered when there are no projects, so the assertion timed out.

The toolbar guard belongs in filterProjectByName(), the only caller
that actually interacts with the toolbar. private wait() keeps just
the page-title check, which works for all page states.

---------

Co-authored-by: Bob Gregor <Bob Gregor>

Author: bobbravo2

packages/cypress/cypress/pages/projects.ts

@@ -77,20 +77,14 @@ class ProjectListPage {
   }
 
   private wait() {
-    cy.findByTestId('app-page-title');
+    cy.findByTestId('app-page-title', { timeout: 15000 }).should('be.visible');
     cy.testA11y();
   }
 
   findPageTitle() {
     return cy.findByTestId('app-page-title');
   }
 
-  waitForPageAndToolbar() {
-    this.findPageTitle().should('be.visible', { timeout: 15000 });
-    this.getTableToolbar().find().should('be.visible', { timeout: 30000 });
-    return this;
-  }
-
   shouldHaveProjects() {
     this.findProjectsTable().should('exist');
     return this;
@@ -151,6 +145,7 @@ class ProjectListPage {
    * @param projectName Project Name
    */
   filterProjectByName = (projectName: string) => {
+    cy.findByTestId('projects-table-toolbar', { timeout: 30000 }).should('be.visible');
     const projectListToolbar = projectListPage.getTableToolbar();
     projectListToolbar.findNameFilter().type(projectName);
   };

packages/cypress/cypress/tests/e2e/dataScienceProjects/clusterStorage/testClusterStorageAccessModes.cy.ts

@@ -78,9 +78,10 @@ describe('Cluster Storage Access Modes Tests', () => {
 
   beforeEach(() => {
     cy.step('Log into the application');
-    cy.visitWithLogin('/projects', HTPASSWD_CLUSTER_ADMIN_USER);
+    cy.visitWithLogin('/', HTPASSWD_CLUSTER_ADMIN_USER);
 
     cy.step(`Navigate to the Project list tab and search for ${projectName}`);
+    projectListPage.navigate();
     projectListPage.filterProjectByName(projectName);
     projectListPage.findProjectLink(projectName).click();
 

packages/cypress/cypress/tests/e2e/dataScienceProjects/testProjectAdminPermissions.cy.ts

@@ -129,7 +129,6 @@ describe('Verify that users can provide admin project permissions to non-admin u
 
       cy.step('Verify that the user has access to the created project and can access Permissions');
       projectListPage.navigate();
-      projectListPage.waitForPageAndToolbar();
       projectListPage.filterProjectByName(projectName);
       projectListPage.findProjectLink(projectName).click();
       projectDetails.findSectionTab('permissions').click();

packages/cypress/cypress/tests/e2e/dataScienceProjects/testProjectContributorPermissions.cy.ts

@@ -79,7 +79,6 @@ describe('Verify that users can provide contributor project permissions to non-a
         'Verify that the user has access to the created project but cannot access Permissions',
       );
       projectListPage.navigate();
-      projectListPage.waitForPageAndToolbar();
       projectListPage.filterProjectByName(projectName);
       projectListPage.findProjectLink(projectName).click();
       cy.log('Attempting to find permissions tab which should not be visible');

packages/cypress/cypress/tests/e2e/dataScienceProjects/workbenches/testWorkbenchStorageClasses.cy.ts

@@ -110,9 +110,10 @@ describe('Workbench Storage Classes Tests', () => {
 
   beforeEach(() => {
     cy.step('Log into the application');
-    cy.visitWithLogin('/projects', HTPASSWD_CLUSTER_ADMIN_USER);
+    cy.visitWithLogin('/', HTPASSWD_CLUSTER_ADMIN_USER);
 
     cy.step(`Navigate to the Project list tab and search for ${projectName}`);
+    projectListPage.navigate();
     projectListPage.filterProjectByName(projectName);
     projectListPage.findProjectLink(projectName).click();
   });

packages/cypress/cypress/tests/e2e/storageClasses/clusterStorage.cy.ts

@@ -46,9 +46,10 @@ describe('Regular Users can make use of the Storage Classes in the Cluster Stora
     { tags: ['@Smoke', '@SmokeSet2', '@Dashboard', '@NonConcurrent'] },
     () => {
       // Authentication and navigation
-      cy.visitWithLogin('/projects', LDAP_CONTRIBUTOR_USER);
+      cy.visitWithLogin('/', LDAP_CONTRIBUTOR_USER);
       // Open the project
       cy.step(`Navigate to the Project list tab and search for ${dspName}`);
+      projectListPage.navigate();
       projectListPage.filterProjectByName(dspName);
       projectListPage.findProjectLink(dspName).click();
       cy.step('Navigate to the Cluster Storage tab and disable all non-default storage classes');