mr props test

Author: ConorOM1

packages/cypress/cypress/fixtures/e2e/modelRegistry/testRetainCustomProperties.yaml

@@ -0,0 +1,59 @@
+# Test data for custom properties retention tests
+# Tests verify no data loss on related objects during model registry operations
+
+# Registry and database configuration
+registryNamePrefix: "test-props-registry"
+databaseNamePrefix: "props-db"
+projectNamePrefix: "props-deploy-project"
+operatorDeploymentName: "model-registry-operator-controller-manager"
+
+# Model configuration
+modelNamePrefix: "test-props-model"
+modelDescription: "Test model for verifying custom properties retention during operations"
+
+# Model custom properties
+modelCustomProperties:
+  - key: "model-prop-1"
+    value: "model-value-1"
+
+# Model labels
+modelLabels:
+  - "model-label-1"
+  - "model-label-2"
+
+# Version configuration
+versionName: "v1.0"
+versionDescription: "Test version for verifying custom properties retention"
+
+# Version custom properties
+versionCustomProperties:
+  - key: "version-prop-1"
+    value: "version-value-1"
+
+# Version labels
+versionLabels:
+  - "version-label-1"
+  - "version-label-2"
+
+# Model format configuration
+sourceModelFormat: "onnx"
+sourceModelFormatVersion: "1.0"
+
+# Updated values for edit tests
+updatedVersionDescription: "Updated description for version - testing properties retention"
+updatedModelFormat: "pytorch"
+updatedFormatVersion: "2.0"
+newVersionLabel: "new-version-label"
+newVersionPropertyKey: "new-version-prop"
+newVersionPropertyValue: "new-version-value"
+
+# Object storage configuration (for model registration)
+objectStorageEndpoint: "http://minio.example.com:9000"
+objectStorageBucket: "test-models"
+objectStorageRegion: "us-east-1"
+objectStoragePath: "models/retain-props-test/v1.0"
+
+# Model format for deployment test
+modelFormatForDeployment: "openvino_ir - opset13"
+servingRuntimeForDeployment: "OpenVINO Model Server"
+modelPathForDeployment: "kserve-openvino-test/openvino-example-model"

packages/cypress/cypress/pages/modelRegistry.ts

@@ -218,6 +218,10 @@ class ModelRegistry {
     return cy.findByTestId('breadcrumb-model');
   }
 
+  findModelVersionBreadcrumbItem() {
+    return cy.findByTestId('breadcrumb-model-version');
+  }
+
   findModelVersionsTableKebab() {
     return cy.findByTestId('model-versions-table-kebab-action');
   }
@@ -250,6 +254,10 @@ class ModelRegistry {
     return cy.findByTestId('empty-model-registry-secondary-action', { timeout });
   }
 
+  findModelOverviewTab() {
+    return cy.findByTestId('model-overview-tab');
+  }
+
   findModelVersionsTab() {
     return cy.findByTestId('model-versions-tab');
   }

packages/cypress/cypress/pages/modelRegistry/modelVersionDetails.ts

@@ -0,0 +1,84 @@
+/**
+ * Page object for Model Version Details page
+ * Handles interactions with version properties, labels, and metadata editing
+ *
+ * On the version details page there are two properties-expandable-section elements:
+ * one inside the collapsed parent model card and one in the version details card.
+ * All selectors here use .last() to target the version's section.
+ */
+
+class ModelVersionDetails {
+  findPropertiesExpandableSection() {
+    return cy.findAllByTestId('properties-expandable-section').last();
+  }
+
+  findPropertiesTable() {
+    return this.findPropertiesExpandableSection().findByTestId('properties-table');
+  }
+
+  findAddPropertyButton() {
+    return this.findPropertiesExpandableSection().findByTestId('add-property-button');
+  }
+
+  findPropertyKeyInput() {
+    return this.findPropertiesExpandableSection().findByTestId('add-property-key-input');
+  }
+
+  findPropertyValueInput() {
+    return this.findPropertiesExpandableSection().findByTestId('add-property-value-input');
+  }
+
+  findSavePropertyButton() {
+    return this.findPropertiesExpandableSection().findByTestId('save-edit-button-property');
+  }
+
+  findDiscardPropertyButton() {
+    return this.findPropertiesExpandableSection().findByTestId('discard-edit-button-property');
+  }
+
+  findPropertiesToggleButton() {
+    return this.findPropertiesExpandableSection().find('button[aria-expanded]').first();
+  }
+
+  findExpandPropertiesButton() {
+    return this.findPropertiesExpandableSection().findByTestId('expand-control-button');
+  }
+
+  // Helper to add a custom property
+  addCustomProperty(key: string, value: string) {
+    this.findAddPropertyButton().click();
+    this.findPropertyKeyInput().type(key);
+    this.findPropertyValueInput().type(value);
+    this.findSavePropertyButton().click();
+  }
+
+  // Helper to verify custom property exists
+  shouldHaveCustomProperty(key: string, value: string) {
+    this.findPropertiesExpandableSection().within(() => {
+      cy.contains(key).should('be.visible');
+      cy.contains(value).should('be.visible');
+    });
+    return this;
+  }
+
+  // Labels section
+  findLabel(labelText: string) {
+    return cy.findByTestId('label').contains(labelText);
+  }
+
+  findLabelGroup() {
+    return cy.findByTestId('popover-label-group');
+  }
+
+  findModalLabelGroup() {
+    return cy.findByTestId('modal-label-group');
+  }
+
+  // Helper to verify label exists
+  shouldHaveLabel(labelText: string) {
+    cy.contains(labelText).should('be.visible');
+    return this;
+  }
+}
+
+export const modelVersionDetails = new ModelVersionDetails();

packages/cypress/cypress/pages/modelRegistry/registeredModelDetails.ts

@@ -0,0 +1,96 @@
+/**
+ * Page object for Registered Model Details page
+ * Handles interactions with model properties, labels, and metadata editing
+ */
+
+class RegisteredModelDetails {
+  // Properties section
+  findPropertiesExpandableSection() {
+    return cy.findByTestId('properties-expandable-section').first();
+  }
+
+  findPropertiesTable() {
+    return cy.findByTestId('properties-table');
+  }
+
+  findAddPropertyButton() {
+    return cy.findByTestId('add-property-button');
+  }
+
+  findPropertyKeyInput() {
+    return cy.findByTestId('add-property-key-input');
+  }
+
+  findPropertyValueInput() {
+    return cy.findByTestId('add-property-value-input');
+  }
+
+  findSavePropertyButton() {
+    return cy.findByTestId('save-edit-button-property');
+  }
+
+  findDiscardPropertyButton() {
+    return cy.findByTestId('discard-edit-button-property');
+  }
+
+  findPropertiesToggleButton() {
+    return this.findPropertiesExpandableSection().find('button[aria-expanded]').first();
+  }
+
+  ensurePropertiesExpanded() {
+    this.findPropertiesToggleButton()
+      .scrollIntoView()
+      .then(($btn) => {
+        if ($btn.attr('aria-expanded') === 'false') {
+          cy.wrap($btn).click();
+        }
+      });
+    this.findPropertiesExpandableSection()
+      .find('.pf-v6-c-expandable-section__content')
+      .first()
+      .should('not.have.css', 'visibility', 'hidden');
+  }
+
+  findExpandPropertiesButton() {
+    return cy.findByTestId('expand-control-button');
+  }
+
+  // Helper to add a custom property
+  addCustomProperty(key: string, value: string) {
+    this.findPropertiesExpandableSection().click();
+    this.findAddPropertyButton().click();
+    this.findPropertyKeyInput().type(key);
+    this.findPropertyValueInput().type(value);
+    this.findSavePropertyButton().click();
+  }
+
+  // Helper to verify custom property exists
+  shouldHaveCustomProperty(key: string, value: string) {
+    this.findPropertiesExpandableSection().within(() => {
+      cy.contains(key).should('be.visible');
+      cy.contains(value).should('be.visible');
+    });
+    return this;
+  }
+
+  // Labels section
+  findLabel(labelText: string) {
+    return cy.findByTestId('label').contains(labelText);
+  }
+
+  findLabelGroup() {
+    return cy.findByTestId('popover-label-group');
+  }
+
+  findModalLabelGroup() {
+    return cy.findByTestId('modal-label-group');
+  }
+
+  // Helper to verify label exists
+  shouldHaveLabel(labelText: string) {
+    cy.contains(labelText).should('be.visible');
+    return this;
+  }
+}
+
+export const registeredModelDetails = new RegisteredModelDetails();