added form limits for workbench, PVC, and project resource names (#3698)

Author: rsun19

frontend/src/concepts/k8s/K8sNameDescriptionField/__tests__/utils.spec.ts

@@ -2,6 +2,7 @@ import {
   handleUpdateLogic,
   isK8sNameDescriptionDataValid,
   LimitNameResourceType,
+  resourceTypeLimits,
   setupDefaults,
 } from '~/concepts/k8s/K8sNameDescriptionField/utils';
 import { K8sNameDescriptionFieldData } from '~/concepts/k8s/K8sNameDescriptionField/types';
@@ -74,6 +75,81 @@ describe('setupDefaults', () => {
       }),
     );
   });
+
+  it('should limit PVC resource name', () => {
+    expect(
+      setupDefaults({
+        initialData: mockProjectK8sResource({
+          displayName:
+            'this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test ',
+          k8sName: '',
+          description: 'my description',
+        }),
+        limitNameResourceType: LimitNameResourceType.PVC,
+      }),
+    ).toEqual(
+      mockK8sNameDescriptionFieldData({
+        name: 'this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test ',
+        description: 'my description',
+        k8sName: {
+          value: 'this-is-a-test-this-is-a-test-this-is-a-test-this-is-a-test-thi',
+          state: {
+            immutable: false,
+            maxLength: resourceTypeLimits[LimitNameResourceType.PVC],
+          },
+        },
+      }),
+    );
+  });
+
+  it('should limit project/workbench resource name', () => {
+    expect(
+      setupDefaults({
+        initialData: mockProjectK8sResource({
+          displayName:
+            'this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test ',
+          k8sName: '',
+          description: 'my description',
+        }),
+        limitNameResourceType: LimitNameResourceType.PROJECT,
+      }),
+    ).toEqual(
+      mockK8sNameDescriptionFieldData({
+        name: 'this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test ',
+        description: 'my description',
+        k8sName: {
+          value: 'this-is-a-test-this-is-a-test',
+          state: {
+            immutable: false,
+            maxLength: resourceTypeLimits[LimitNameResourceType.PROJECT],
+          },
+        },
+      }),
+    );
+    expect(
+      setupDefaults({
+        initialData: mockProjectK8sResource({
+          displayName:
+            'this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test ',
+          k8sName: '',
+          description: 'my description',
+        }),
+        limitNameResourceType: LimitNameResourceType.WORKBENCH,
+      }),
+    ).toEqual(
+      mockK8sNameDescriptionFieldData({
+        name: 'this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test this is a test ',
+        description: 'my description',
+        k8sName: {
+          value: 'this-is-a-test-this-is-a-test',
+          state: {
+            immutable: false,
+            maxLength: resourceTypeLimits[LimitNameResourceType.WORKBENCH],
+          },
+        },
+      }),
+    );
+  });
 });
 
 describe('handleUpdateLogic', () => {

frontend/src/concepts/k8s/K8sNameDescriptionField/utils.ts

@@ -31,10 +31,19 @@ export enum LimitNameResourceType {
   /** Workbenches create routes */
   WORKBENCH,
   // TODO: Support Model Serving?
+  PVC,
 }
 /** K8s max DNS subdomain name length */
 const MAX_RESOURCE_NAME_LENGTH = 253;
 
+const MAX_PVC_NAME_LENGTH = 63;
+
+export const resourceTypeLimits: Record<LimitNameResourceType, number> = {
+  [LimitNameResourceType.PROJECT]: ROUTE_BASED_NAME_LENGTH,
+  [LimitNameResourceType.WORKBENCH]: ROUTE_BASED_NAME_LENGTH,
+  [LimitNameResourceType.PVC]: MAX_PVC_NAME_LENGTH,
+};
+
 export const isK8sNameDescriptionType = (
   x?: K8sNameDescriptionType | K8sResourceCommon,
 ): x is K8sNameDescriptionType => !!x && 'k8sName' in x;
@@ -64,7 +73,7 @@ export const setupDefaults = ({
   }
 
   if (limitNameResourceType != null) {
-    configuredMaxLength = ROUTE_BASED_NAME_LENGTH;
+    configuredMaxLength = resourceTypeLimits[limitNameResourceType];
   }
 
   return handleUpdateLogic({

frontend/src/pages/projects/screens/spawner/storage/CreateNewStorageSection.tsx

@@ -8,7 +8,10 @@ import { PersistentVolumeClaimKind } from '~/k8sTypes';
 import K8sNameDescriptionField, {
   useK8sNameDescriptionFieldData,
 } from '~/concepts/k8s/K8sNameDescriptionField/K8sNameDescriptionField';
-import { isK8sNameDescriptionDataValid } from '~/concepts/k8s/K8sNameDescriptionField/utils';
+import {
+  isK8sNameDescriptionDataValid,
+  LimitNameResourceType,
+} from '~/concepts/k8s/K8sNameDescriptionField/utils';
 import StorageClassSelect from './StorageClassSelect';
 
 type CreateNewStorageSectionProps<D extends StorageData> = {
@@ -44,6 +47,7 @@ const CreateNewStorageSection = <D extends StorageData>({
         k8sName: data.k8sName,
         description: data.description,
       },
+      limitNameResourceType: LimitNameResourceType.PVC,
       editableK8sName,
     });