Skip to content

Commit 8b4dce8

Browse files
mturleyclaude
andcommitted
Remove unused providers from McpDeploymentsWrapper
AppContext, NotificationContextProvider, and NotificationListener were carried over from the upstream wrapper pattern but nothing in the MCP deployments code consumes them. Toast notifications were removed in #7178 and no page calls useAppContext. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
1 parent 54bf399 commit 8b4dce8

1 file changed

Lines changed: 8 additions & 22 deletions

File tree

packages/model-registry/src/odh/McpDeploymentsWrapper.tsx

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,17 @@ import React from 'react';
22
import { Bullseye } from '@patternfly/react-core';
33
import {
44
BrowserStorageContextProvider,
5-
NotificationContextProvider,
65
ModularArchContextProvider,
76
ModularArchConfig,
87
DeploymentMode,
98
useSettings,
109
} from 'mod-arch-core';
1110
import { ThemeProvider, Theme } from 'mod-arch-kubeflow';
1211
import { BFF_API_VERSION, URL_PREFIX } from '../../upstream/frontend/src/app/utilities/const';
13-
import { AppContext } from '../../upstream/frontend/src/app/context/AppContext';
1412
import McpDeploymentsRoutes from '../pages/mcpDeployments/McpDeploymentsRoutes';
15-
import NotificationListener from '../../upstream/frontend/src/odh/components/NotificationListener';
1613

1714
const McpDeploymentsWrapperContent: React.FC = () => {
18-
const { configSettings, userSettings, loaded, loadError } = useSettings();
19-
const contextValue = React.useMemo(
20-
() =>
21-
configSettings && userSettings ? { config: configSettings, user: userSettings } : undefined,
22-
[configSettings, userSettings],
23-
);
15+
const { loaded, loadError } = useSettings();
2416

2517
if (loadError) {
2618
return <div>Error: {loadError.message}</div>;
@@ -29,19 +21,13 @@ const McpDeploymentsWrapperContent: React.FC = () => {
2921
return <Bullseye>Loading...</Bullseye>;
3022
}
3123

32-
return contextValue ? (
33-
<AppContext.Provider value={contextValue}>
34-
<ThemeProvider theme={Theme.Patternfly}>
35-
<BrowserStorageContextProvider>
36-
<NotificationContextProvider>
37-
<NotificationListener>
38-
<McpDeploymentsRoutes />
39-
</NotificationListener>
40-
</NotificationContextProvider>
41-
</BrowserStorageContextProvider>
42-
</ThemeProvider>
43-
</AppContext.Provider>
44-
) : null;
24+
return (
25+
<ThemeProvider theme={Theme.Patternfly}>
26+
<BrowserStorageContextProvider>
27+
<McpDeploymentsRoutes />
28+
</BrowserStorageContextProvider>
29+
</ThemeProvider>
30+
);
4531
};
4632

4733
const McpDeploymentsWrapper: React.FC = () => {

0 commit comments

Comments
 (0)