Revert "fix(bff): add retry logic for configmap conflicts on catalog source update"

This reverts commit 97d2a3d33ab7495ca90ff22b60d8ad76dc2495b6.

Author: manaswinidas

packages/model-registry/upstream/bff/internal/repositories/model_catalog_settings.go

@@ -220,43 +220,12 @@ func (r *ModelCatalogSettingsRepository) CreateCatalogSourceConfig(
 	return r.GetCatalogSourceConfig(ctx, client, namespace, payload.Id)
 }
 
-const maxConflictRetries = 3
-
 func (r *ModelCatalogSettingsRepository) UpdateCatalogSourceConfig(
 	ctx context.Context,
 	client k8s.KubernetesClientInterface,
 	namespace string,
 	sourceId string,
 	payload models.CatalogSourceConfigPayload,
-) (*models.CatalogSourceConfig, error) {
-	var lastErr error
-	for attempt := 1; attempt <= maxConflictRetries; attempt++ {
-		result, err := r.tryUpdateCatalogSourceConfig(ctx, client, namespace, sourceId, payload)
-		if err == nil {
-			return result, nil
-		}
-		if !errors.Is(err, ErrCatalogSourceConflict) {
-			return nil, err
-		}
-		lastErr = err
-		if attempt < maxConflictRetries {
-			sessionLogger := ctx.Value(constants.TraceLoggerKey).(*slog.Logger)
-			sessionLogger.Warn("configmap conflict detected, retrying",
-				"sourceId", sourceId,
-				"attempt", attempt,
-				"maxRetries", maxConflictRetries,
-			)
-		}
-	}
-	return nil, lastErr
-}
-
-func (r *ModelCatalogSettingsRepository) tryUpdateCatalogSourceConfig(
-	ctx context.Context,
-	client k8s.KubernetesClientInterface,
-	namespace string,
-	sourceId string,
-	payload models.CatalogSourceConfigPayload,
 ) (*models.CatalogSourceConfig, error) {
 	defaultCM, userCM, err := client.GetAllCatalogSourceConfigs(ctx, namespace)
 	if err != nil {
@@ -380,6 +349,7 @@ func (r *ModelCatalogSettingsRepository) tryUpdateCatalogSourceConfig(
 	}
 
 	return r.GetCatalogSourceConfig(ctx, client, namespace, sourceId)
+
 }
 
 func (r *ModelCatalogSettingsRepository) DeleteCatalogSourceConfig(