added correct filtering for mlflow in app launcher (#5795)

* added correct filtering for mlflow in app launcher

* added test case

Author: rsun19

frontend/src/app/AppLauncher.tsx

@@ -77,7 +77,7 @@ const AppLauncher: React.FC = () => {
         (link) =>
           link.spec.location === 'ApplicationMenu' &&
           !appConsoleLinkNames.includes(link.metadata?.name ?? '') &&
-          (isMLflowEnabled || link.metadata?.name !== 'mlflowlink'),
+          (isMLflowEnabled || !(link.metadata?.name && link.metadata.name.startsWith('mlflow'))),
       )
       .toSorted((a, b) => a.spec.text.localeCompare(b.spec.text));
 

packages/cypress/cypress/tests/mocked/applications/application.cy.ts

@@ -3,7 +3,11 @@ import {
   mockDscStatus,
   dataScienceStackComponentMap,
 } from '@odh-dashboard/internal/__mocks__';
-import { mockConsoleLinks } from '@odh-dashboard/internal/__mocks__/mockConsoleLinks';
+import {
+  mockConsoleLinks,
+  mockMLflowLink,
+  mockOpenDataHubConsoleLink,
+} from '@odh-dashboard/internal/__mocks__/mockConsoleLinks';
 import { DataScienceStackComponent } from '@odh-dashboard/internal/concepts/areas/types';
 import { OdhPlatformType } from '@odh-dashboard/internal/types';
 import { appChrome } from '../../../pages/appChrome';
@@ -48,7 +52,23 @@ describe('Application', () => {
   });
 
   it('Validate clicking on App Launcher opens menu', () => {
-    cy.interceptOdh('GET /api/console-links', mockConsoleLinks());
+    cy.interceptOdh(
+      'GET /api/console-links',
+      mockConsoleLinks([
+        mockOpenDataHubConsoleLink,
+        mockMLflowLink,
+        {
+          ...mockMLflowLink,
+          metadata: {
+            name: 'mlflow-1234',
+          },
+          spec: {
+            ...mockMLflowLink.spec,
+            text: 'MLflow test 1234',
+          },
+        },
+      ]),
+    );
     cy.interceptOdh('GET /api/config', mockDashboardConfig({ mlflow: true }));
     appChrome.visit();
     const applicationLauncher = appChrome.getApplicationLauncher();
@@ -60,6 +80,7 @@ describe('Application', () => {
 
     // Have the MLflow link
     applicationLauncherMenuGroupStatic.shouldHaveApplicationLauncherItem('MLflow');
+    applicationLauncherMenuGroupStatic.shouldHaveApplicationLauncherItem('MLflow test 1234');
 
     applicationLauncherMenuGroupStatic
       .findApplicationLauncherItem('MLflow')