Update odh-dashboard manifests for dashboard v2.0 release (#588)

Add odh-dashboard v2.0 files

* odh-dashboard: Set authentication overlay as the default deployment method
* Add real defaults to JH groups config
* Add odh-jupyterhub-admins as the default admin_groups
* Add system:authenticated as the default allowed_groups
* Add check for ODHDashboardConfigs in the dashboard CI test

Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>

Author: LaVLaS

jupyterhub/jupyterhub/base/jupyterhub-groups-configmap.yaml

@@ -5,5 +5,5 @@ metadata:
     app: jupyterhub
   name: jupyterhub-default-groups-config
 data:
-  admin_groups: ""
-  allowed_groups: ""
+  admin_groups: "odh-jupyterhub-admins"
+  allowed_groups: "system:authenticated"

kfdef/kfctl_openshift.yaml

@@ -100,6 +100,8 @@ spec:
         path: model-mesh
     name: model-mesh
   - kustomizeConfig:
+      overlays:
+      - authentication
       repoRef:
         name: manifests
         path: odh-dashboard

odh-dashboard/base/cluster-role-binding.yaml

@@ -5,7 +5,6 @@ metadata:
 subjects:
   - kind: ServiceAccount
     name: odh-dashboard
-    namespace: redhat-ods-applications
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole

odh-dashboard/base/deployment.yaml

@@ -27,7 +27,7 @@ spec:
       serviceAccount: odh-dashboard
       containers:
       - name: odh-dashboard
-        image: quay.io/opendatahub/odh-dashboard:v1.0
+        image: quay.io/opendatahub/odh-dashboard:v2.0
         imagePullPolicy: Always
         ports:
         - containerPort: 8080

odh-dashboard/base/kustomization.yaml

@@ -4,6 +4,7 @@ commonLabels:
   app: odh-dashboard
   app.kubernetes.io/part-of: odh-dashboard
 resources:
+- odh-dashboard-crd.yaml
 - role.yaml
 - cluster-role.yaml
 - service-account.yaml
@@ -12,4 +13,3 @@ resources:
 - deployment.yaml
 - routes.yaml
 - service.yaml
-- odh-dashboard-crd.yaml

odh-dashboard/base/role.yaml

@@ -19,12 +19,53 @@ rules:
       - get
       - list
       - watch
+  - apiGroups:
+      - ''
+    verbs:
+      - create
+      - delete
+      - get
+      - list
+      - patch
+      - update
+      - watch
+    resources:
+      - configmaps
+      - secrets
+  - apiGroups:
+      - batch
+    verbs:
+      - create
+      - delete
+      - get
+      - list
+      - patch
+      - update
+      - watch
+    resources:
+      - cronjobs
+      - jobs
+      - jobs/status
+  - apiGroups:
+      - image.openshift.io
+    verbs:
+      - create
+      - get
+      - list
+      - update
+      - patch
+      - delete
+    resources:
+      - imagestreams
   - apiGroups:
       - build.openshift.io
     verbs:
       - get
       - list
       - watch
+      - create
+      - patch
+      - delete
     resources:
       - builds
       - buildconfigs
@@ -48,3 +89,15 @@ rules:
     resources:
       - deploymentconfigs
       - deploymentconfigs/instantiate
+  - apiGroups:
+      - opendatahub.io
+    verbs:
+      - get
+      - list
+      - watch
+      - create
+      - update
+      - patch
+      - delete
+    resources:
+      - odhdashboardconfigs

odh-dashboard/overlays/authentication/deployment.yaml

@@ -12,7 +12,7 @@
       - --cookie-secret=SECRET
       - '--openshift-delegate-urls={"/": {"resource": "route", "verb": "get", "name": "odh-dashboard"}}'
       - --skip-auth-regex=^/metrics
-    image: quay.io/openshift/origin-oauth-proxy:4.8.0
+    image: registry.redhat.io/openshift4/ose-oauth-proxy:v4.8
     ports:
       - containerPort: 8443
         name: https

tests/basictests/dashboard.sh

@@ -12,6 +12,7 @@ function check_resources() {
     header "Testing dashboard installation"
     os::cmd::expect_success "oc project ${ODHPROJECT}"
     os::cmd::try_until_text "oc get odh-dashboard odh-dashboard" "odh-dashboard" $odhdefaulttimeout $odhdefaultinterval
+    os::cmd::try_until_text "oc get crd odhdashboardconfigs " "odhdashboardconfigs" $odhdefaulttimeout $odhdefaultinterval
     os::cmd::try_until_text "oc get role odh-dashboard" "odh-dashboard" $odhdefaulttimeout $odhdefaultinterval
     os::cmd::try_until_text "oc get rolebinding odh-dashboard" "odh-dashboard" $odhdefaulttimeout $odhdefaultinterval
     os::cmd::try_until_text "oc get route odh-dashboard" "odh-dashboard" $odhdefaulttimeout $odhdefaultinterval
@@ -26,8 +27,8 @@ function check_ui() {
     local route="https://"$(oc get route odh-dashboard -o jsonpath='{.spec.host}')
     os::log::info "$route"
     os::cmd::try_until_text "curl -k -s -o /dev/null -w \"%{http_code}\" $route/api/components" "200" $odhdefaulttimeout $odhdefaultinterval
-    os::cmd::try_until_text "curl -k $route/api/components | jq '.[].key'" "jupyterhub" $odhdefaulttimeout $odhdefaultinterval
-    os::cmd::try_until_text "curl -k $route" "<title>Open Data Hub Dashboard</title>" $odhdefaulttimeout $odhdefaultinterval
+    os::cmd::try_until_text "curl -k $route/api/components | jq '.[].metadata.name'" "jupyterhub" $odhdefaulttimeout $odhdefaultinterval
+    os::cmd::try_until_text "curl -k $route" "<title>Open Data Hub</title>" $odhdefaulttimeout $odhdefaultinterval
 }
 
 check_resources