Skip to content

Commit 00dcb25

Browse files
committed
address comment 1
Signed-off-by: Milind Waykole <mwaykole@redhat.com>
1 parent d74b514 commit 00dcb25

File tree

1 file changed

+8
-7
lines changed
  • tests/model_serving/model_server/keda

1 file changed

+8
-7
lines changed

tests/model_serving/model_server/keda/utils.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def get_isvc_keda_scaledobject(client: DynamicClient, isvc: InferenceService) ->
1313
isvc (InferenceService): InferenceService object.
1414
1515
Returns:
16-
list[ScaledObject]: A list of all matching ScaledObjects
16+
list[ScaledObject]: A list containing the ScaledObject
1717
1818
Raises:
1919
ResourceNotFoundError: if no ScaledObjects are found.
@@ -22,11 +22,12 @@ def get_isvc_keda_scaledobject(client: DynamicClient, isvc: InferenceService) ->
2222
scaled_object_name = isvc.name + "-predictor"
2323

2424
try:
25-
scaled_objects = list(ScaledObject.get(dyn_client=client, namespace=namespace, name=scaled_object_name))
26-
27-
if scaled_objects:
28-
return scaled_objects
29-
else:
30-
raise ResourceNotFoundError(f"{isvc.name} has no KEDA ScaledObjects")
25+
scaled_object = ScaledObject(
26+
client=client,
27+
name=scaled_object_name,
28+
namespace=namespace,
29+
ensure_exists=True
30+
)
31+
return [scaled_object]
3132
except Exception as e:
3233
raise ResourceNotFoundError(f"{isvc.name} has no KEDA ScaledObjects: {e}")

0 commit comments

Comments
 (0)