Skip to content

Commit 0257962

Browse files
authored
Merge branch 'main' into signing_image_tests
2 parents 9434a22 + 5e62a40 commit 0257962

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CONSTITUTION.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,11 @@ All code MUST consider security implications.
7979
- Avoid running destructive commands without explicit user confirmation
8080
- Use detect-secrets and gitleaks pre-commit hooks to prevent secret leakage
8181
- Test code MUST NOT introduce vulnerabilities into the tested systems
82+
- JIRA ticket links are allowed in PRs and commit messages (our Jira is public)
83+
- Do NOT reference internal-only resources (Jenkins, Confluence, Slack threads) in code, PRs, or commit messages
84+
- Do NOT link embargoed or security-restricted (RH-employee-only) tickets
8285

83-
**Rationale**: Tests interact with production-like clusters; security lapses can have real consequences.
86+
**Rationale**: Tests interact with production-like clusters; security lapses can have real consequences. This is a public repository — only reference publicly accessible resources.
8487

8588
## Test Development Standards
8689

tests/model_registry/mcp_servers/search/test_filtering.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ class TestMCPServerFiltering:
2424
id="by_provider",
2525
),
2626
pytest.param("tags='math'", 1, CALCULATOR_SERVER_NAME, None, id="by_tags"),
27+
pytest.param("license='BSD 3-Clause'", 1, "file-manager", ("license", "BSD 3-Clause"), id="by_license"),
2728
],
2829
)
2930
def test_filter_by_field(
@@ -35,7 +36,7 @@ def test_filter_by_field(
3536
expected_name: str,
3637
field_check: tuple[str, str] | None,
3738
):
38-
"""TC-API-003, TC-API-005: Test filtering MCP servers by provider and tags."""
39+
"""TC-API-003, TC-API-005, TC-API-009: Test filtering MCP servers by provider, tags, and license."""
3940
response = execute_get_command(
4041
url=f"{mcp_catalog_rest_urls[0]}mcp_servers",
4142
headers=model_registry_rest_headers,

tests/model_registry/mcp_servers/search/test_ordering.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
class TestMCPServerOrdering:
1313
"""RHOAIENG-51584: Tests for MCP server ordering functionality."""
1414

15-
@pytest.mark.xfail(reason="RHOAIENG-52448: sortOrder/orderBy not working, fix in PR #2367")
1615
@pytest.mark.parametrize(
1716
"sort_order",
1817
[

0 commit comments

Comments
 (0)