pr comments

Author: threcc

tests/model_serving/model_server/upgrade/conftest.py

@@ -801,6 +801,7 @@ def llmd_namespace_fixture(
 def llmd_gateway_fixture(
     pytestconfig: pytest.Config,
     admin_client: DynamicClient,
+    teardown_resources: bool,
 ) -> Generator[Gateway, Any, Any]:
     """Shared LLMD Gateway for upgrade tests."""
     gateway = Gateway(
@@ -820,7 +821,7 @@ def llmd_gateway_fixture(
             gateway_class_name=LLMDGateway.DEFAULT_CLASS,
             wait_for_condition=True,
             timeout=Timeout.TIMEOUT_1MIN,
-            teardown=False,
+            teardown=teardown_resources,
         ) as gateway:
             yield gateway
 

tests/model_serving/model_server/upgrade/utils.py

@@ -400,6 +400,9 @@ def verify_gateway_accepted(gateway: Gateway) -> None:
         raise AssertionError(f"Gateway {gateway.name} does not exist in namespace {gateway.namespace}")
 
     conditions = gateway.instance.status.get("conditions", [])
-    accepted = any(c.get("type") == "Accepted" and c.get("status") == "True" for c in conditions)
-    if not accepted:
+    is_accepted = any(
+        condition.get("type") == "Accepted" and condition.get("status") == "True"
+        for condition in conditions
+    )
+    if not is_accepted:
         raise AssertionError(f"Gateway {gateway.name} is not Accepted. Conditions: {conditions}")