Skip to content

Commit 1c31c05

Browse files
jiridanekclaude
andcommitted
fix: update expected notebook ImageStream count from 11 to 14
Three new training-hub-universal ImageStreams (cpu, cuda, rocm) from the trainer component now carry the opendatahub.io/notebook-image=true label. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 8a67a44 commit 1c31c05

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tests/workbenches/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ workbenches/
1616

1717
### Current Test Suites
1818

19-
- **`test_imagestream_health.py`** - Validates that workbench ImageStreams are properly imported and resolved. Checks correct ImageStream counts, tag digest references (`@sha256:`), and `ImportSuccess` conditions for both notebook images (11 expected) and runtime images (7 expected)
19+
- **`test_imagestream_health.py`** - Validates that workbench ImageStreams are properly imported and resolved. Checks correct ImageStream counts, tag digest references (`@sha256:`), and `ImportSuccess` conditions for both notebook images (14 expected) and runtime images (7 expected)
2020
- **`notebook-controller/test_spawning.py`** - Tests basic notebook creation via Notebook CR and validates pod creation. Also tests Auth proxy container resource customization via annotations
2121
- **`notebook-controller/test_custom_images.py`** - Validates custom workbench images contain required Python packages by spawning a workbench, installing any missing packages, and executing import verification
2222

tests/workbenches/test_imagestream_health.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def _validate_imagestreams_with_label(
176176
@pytest.mark.parametrize(
177177
"label_selector, expected_imagestream_count",
178178
[
179-
pytest.param("opendatahub.io/notebook-image=true", 11, id="notebook_imagestreams"),
179+
pytest.param("opendatahub.io/notebook-image=true", 14, id="notebook_imagestreams"),
180180
pytest.param("opendatahub.io/runtime-image=true", 7, id="runtime_imagestreams"),
181181
],
182182
)

0 commit comments

Comments
 (0)