Skip to content

Commit 1ebe183

Browse files
committed
fix: address review comments
Signed-off-by: lugi0 <lgiorgi@redhat.com>
1 parent 474560f commit 1ebe183

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

tests/model_registry/async_job/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
import pytest
55
from kubernetes.dynamic import DynamicClient
6+
from kubernetes.dynamic.exceptions import ResourceNotFoundError
67
from ocp_resources.job import Job
78

89
from tests.model_registry.async_job.constants import (
@@ -137,7 +138,7 @@ def async_upload_image(admin_client: DynamicClient) -> str:
137138
)
138139

139140
if not config_map.exists:
140-
raise RuntimeError(
141+
raise ResourceNotFoundError(
141142
"ConfigMap 'model-registry-operator-parameters' not found in namespace 'redhat-ods-applications'"
142143
)
143144

tests/model_registry/async_job/test_async_upload_e2e.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@
5858
],
5959
indirect=True,
6060
)
61+
@pytest.mark.downstream_only
6162
class TestAsyncUploadE2E:
6263
"""RHOAIENG-32501: Test for async upload job with real MinIO, OCI registry, Connection Secrets and Model Registry"""
6364

64-
# FAILS until https://github.com/kubeflow/model-registry/pull/1499 is merged downstream
6565
@pytest.mark.dependency(name="job_creation_and_pod_spawning")
6666
def test_job_creation_and_pod_spawning(
6767
self: Self,

0 commit comments

Comments
 (0)