test: add coverage for mcp tools (#1314)

---------

Signed-off-by: fege <fmosca@redhat.com>

Author: fege

tests/model_registry/mcp_servers/test_data_integrity.py

@@ -2,10 +2,12 @@
 
 import pytest
 import structlog
+from kubernetes.dynamic.exceptions import ResourceNotFoundError
 
 from tests.model_registry.mcp_servers.constants import (
     EXPECTED_MCP_SERVER_NAMES,
     EXPECTED_MCP_SERVER_TIMESTAMPS,
+    EXPECTED_MCP_SERVER_TOOL_COUNTS,
     EXPECTED_MCP_SERVER_TOOLS,
 )
 from tests.model_registry.utils import execute_get_command
@@ -21,13 +23,50 @@ def test_mcp_servers_loaded(
         self: Self,
         mcp_servers_response: dict[str, Any],
     ):
-        """Verify that all MCP servers are loaded from YAML with correct timestamps."""
+        """Verify MCP servers loaded with correct timestamps and tools excluded by default (TC-LOAD-001, TC-API-020)."""
         servers_by_name = {server["name"]: server for server in mcp_servers_response["items"]}
         assert set(servers_by_name) == EXPECTED_MCP_SERVER_NAMES
         for name, server in servers_by_name.items():
             expected = EXPECTED_MCP_SERVER_TIMESTAMPS[name]
             assert server["createTimeSinceEpoch"] == expected["createTimeSinceEpoch"]
             assert server["lastUpdateTimeSinceEpoch"] == expected["lastUpdateTimeSinceEpoch"]
+            assert "tools" not in server or server["tools"] is None, (
+                f"Server '{name}' should not include tools by default"
+            )
+            assert server["toolCount"] == EXPECTED_MCP_SERVER_TOOL_COUNTS[name]
+
+    @pytest.mark.xfail(reason="RHOAIENG-55737 - toolLimit query parameter has no effect on MCP listing endpoint")
+    def test_mcp_server_tool_limit(
+        self: Self,
+        mcp_catalog_rest_urls: list[str],
+        model_registry_rest_headers: dict[str, str],
+    ):
+        """Verify toolLimit caps returned tools array (TC-API-021)."""
+        tool_limit = 1
+        response = execute_get_command(
+            url=f"{mcp_catalog_rest_urls[0]}mcp_servers",
+            headers=model_registry_rest_headers,
+            params={"includeTools": "true", "toolLimit": str(tool_limit)},
+        )
+        for server in response.get("items", []):
+            name = server["name"]
+            assert len(server["tools"]) <= tool_limit, (
+                f"Server '{name}' returned {len(server['tools'])} tools, expected at most {tool_limit}"
+            )
+
+    @pytest.mark.tier3
+    def test_tool_limit_exceeding_maximum(
+        self: Self,
+        mcp_catalog_rest_urls: list[str],
+        model_registry_rest_headers: dict[str, str],
+    ):
+        """Verify toolLimit exceeding maximum (100) is rejected (TC-API-023)."""
+        with pytest.raises(ResourceNotFoundError):
+            execute_get_command(
+                url=f"{mcp_catalog_rest_urls[0]}mcp_servers",
+                headers=model_registry_rest_headers,
+                params={"includeTools": "true", "toolLimit": "101"},
+            )
 
     def test_mcp_server_tools_loaded(
         self: Self,