Skip to content

Commit 2cad5c0

Browse files
committed
feat: add auth test to upgrade
feat: add auth test to upgrade
1 parent 22fc6cb commit 2cad5c0

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

tests/model_serving/model_server/upgrade/conftest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -394,6 +394,7 @@ def model_service_account_scope_session(
394394
namespace=ci_endpoint_s3_secret_scope_session.namespace,
395395
name="upgrade-models-bucket-sa",
396396
secrets=[{"name": ci_endpoint_s3_secret_scope_session.name}],
397+
teardown=teardown_resources,
397398
) as sa:
398399
yield sa
399400

@@ -457,6 +458,7 @@ def http_role_binding_scope_session(
457458
role_ref_kind=http_view_role_scope_session.kind,
458459
subjects_kind=model_service_account_scope_session.kind,
459460
subjects_name=model_service_account_scope_session.name,
461+
teardown=teardown_resources,
460462
) as rb:
461463
yield rb
462464

utilities/infra.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,16 @@ def create_ns(
114114
project.wait_for_status(status=project.Status.ACTIVE, timeout=Timeout.TIMEOUT_2MIN)
115115
yield project
116116

117-
wait_for_serverless_pods_deletion(resource=project, admin_client=admin_client)
117+
if teardown:
118+
wait_for_serverless_pods_deletion(resource=project, admin_client=admin_client)
118119

119120
else:
120121
with Namespace(**namespace_kwargs) as ns:
121122
ns.wait_for_status(status=Namespace.Status.ACTIVE, timeout=Timeout.TIMEOUT_2MIN)
122123
yield ns
123124

124-
wait_for_serverless_pods_deletion(resource=ns, admin_client=admin_client)
125+
if teardown:
126+
wait_for_serverless_pods_deletion(resource=ns, admin_client=admin_client)
125127

126128

127129
def wait_for_replicas_in_deployment(deployment: Deployment, replicas: int) -> None:

0 commit comments

Comments
 (0)