Skip to content

Commit 2f55293

Browse files
committed
fix: address review comments
Signed-off-by: Debarati Basu-Nag <[email protected]>
1 parent 65fe5fd commit 2f55293

File tree

10 files changed

+12
-14
lines changed

10 files changed

+12
-14
lines changed

tests/model_registry/mcp_servers/config/test_source_label.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
from typing import Self
22

33
import pytest
4-
from simple_logger.logger import get_logger
54

65
from tests.model_registry.mcp_servers.constants import (
76
MCP_CATALOG_SOURCE2_NAME,
87
MCP_CATALOG_SOURCE_NAME,
98
)
109
from tests.model_registry.utils import execute_get_command
10+
from utilities.opendatahub_logger import get_logger
1111

1212
LOGGER = get_logger(name=__name__)
1313

tests/model_registry/model_catalog/catalog_config/test_catalog_source_merge.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import pytest
22

33
from tests.model_registry.model_catalog.constants import REDHAT_AI_CATALOG_ID
4-
from tests.model_registry.model_catalog.utils import execute_get_command
4+
from tests.model_registry.utils import execute_get_command
55
from utilities.opendatahub_logger import get_logger
66

77
LOGGER = get_logger(name=__name__)

tests/model_registry/model_catalog/catalog_config/test_default_model_catalog.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
validate_model_catalog_resource,
2323
)
2424
from tests.model_registry.model_catalog.constants import CATALOG_CONTAINER, DEFAULT_CATALOGS, REDHAT_AI_CATALOG_ID
25-
from tests.model_registry.model_catalog.utils import execute_get_command
26-
from tests.model_registry.utils import get_model_catalog_pod, get_rest_headers
25+
from tests.model_registry.utils import execute_get_command, get_model_catalog_pod, get_rest_headers
2726
from utilities.opendatahub_logger import get_logger
2827
from utilities.user_utils import UserTestSession
2928

tests/model_registry/model_catalog/huggingface/test_huggingface_source_error_validation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from ocp_resources.config_map import ConfigMap
77

88
from tests.model_registry.model_catalog.huggingface.utils import assert_accessible_models_via_catalog_api
9-
from tests.model_registry.model_catalog.utils import execute_get_command
9+
from tests.model_registry.utils import execute_get_command
1010
from utilities.opendatahub_logger import get_logger
1111

1212
LOGGER = get_logger(name=__name__)

tests/model_registry/model_catalog/huggingface/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
from timeout_sampler import retry
77

88
from tests.model_registry.model_catalog.constants import HF_SOURCE_ID
9-
from tests.model_registry.model_catalog.utils import execute_get_command, get_models_from_catalog_api
10-
from tests.model_registry.utils import get_model_catalog_pod
9+
from tests.model_registry.model_catalog.utils import get_models_from_catalog_api
10+
from tests.model_registry.utils import execute_get_command, get_model_catalog_pod
1111
from utilities.opendatahub_logger import get_logger
1212

1313
LOGGER = get_logger(name=__name__)

tests/model_registry/model_catalog/metadata/test_custom_properties.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
get_metadata_from_catalog_pod,
1010
validate_custom_properties_match_metadata,
1111
)
12-
from tests.model_registry.model_catalog.utils import execute_get_command
13-
from tests.model_registry.utils import get_model_catalog_pod
12+
from tests.model_registry.utils import execute_get_command, get_model_catalog_pod
1413
from utilities.opendatahub_logger import get_logger
1514

1615
LOGGER = get_logger(name=__name__)

tests/model_registry/model_catalog/metadata/test_sources_endpoint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
REDHAT_AI_CATALOG_ID,
99
VALIDATED_CATALOG_ID,
1010
)
11-
from tests.model_registry.model_catalog.utils import execute_get_command
11+
from tests.model_registry.utils import execute_get_command
1212
from utilities.opendatahub_logger import get_logger
1313

1414
pytestmark = [pytest.mark.usefixtures("updated_dsc_component_state_scope_session", "model_registry_namespace")]

tests/model_registry/model_catalog/metadata/utils.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
from ocp_resources.pod import Pod
1010

1111
from tests.model_registry.constants import DEFAULT_CUSTOM_MODEL_CATALOG, DEFAULT_MODEL_CATALOG_CM
12-
from tests.model_registry.model_catalog.utils import execute_get_command
13-
from tests.model_registry.utils import get_rest_headers
12+
from tests.model_registry.utils import execute_get_command, get_rest_headers
1413
from utilities.opendatahub_logger import get_logger
1514

1615
LOGGER = get_logger(name=__name__)

tests/model_registry/model_catalog/search/utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
SEARCH_MODELS_DB_QUERY,
2020
SEARCH_MODELS_WITH_SOURCE_ID_DB_QUERY,
2121
)
22-
from tests.model_registry.model_catalog.utils import execute_database_query, execute_get_command, parse_psql_output
22+
from tests.model_registry.model_catalog.utils import execute_database_query, parse_psql_output
23+
from tests.model_registry.utils import execute_get_command
2324
from utilities.opendatahub_logger import get_logger
2425

2526
LOGGER = get_logger(name=__name__)

tests/model_serving/maas_billing/maas_subscription/test_api_key_bulk_operations.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22

33
import pytest
44
import requests
5-
from simple_logger.logger import get_logger
65

76
from tests.model_serving.maas_billing.maas_subscription.utils import (
87
assert_bulk_revoke_success,
98
bulk_revoke_api_keys,
109
get_api_key,
1110
resolve_api_key_username,
1211
)
12+
from utilities.opendatahub_logger import get_logger
1313

1414
LOGGER = get_logger(name=__name__)
1515

0 commit comments

Comments
 (0)