Use kw arguments in lmevaljob pod fixtures

Author: adolfo-ab

tests/model_explainability/lm_eval/conftest.py

@@ -399,16 +399,16 @@ def lmevaljob_s3_offline(
 
 @pytest.fixture(scope="function")
 def lmevaljob_hf_pod(admin_client: DynamicClient, lmevaljob_hf: LMEvalJob) -> Generator[Pod, Any, Any]:
-    yield get_lmevaljob_pod(admin_client, lmevaljob_hf)
+    yield get_lmevaljob_pod(client=admin_client, lmevaljob=lmevaljob_hf)
 
 
 @pytest.fixture(scope="function")
 def lmevaljob_vllm_emulator_pod(
     admin_client: DynamicClient, lmevaljob_vllm_emulator: LMEvalJob
 ) -> Generator[Pod, Any, Any]:
-    yield get_lmevaljob_pod(admin_client, lmevaljob_vllm_emulator)
+    yield get_lmevaljob_pod(client=admin_client, lmevaljob=lmevaljob_vllm_emulator)
 
 
 @pytest.fixture(scope="function")
 def lmevaljob_s3_offline_pod(admin_client: DynamicClient, lmevaljob_s3_offline: LMEvalJob) -> Generator[Pod, Any, Any]:
-    yield get_lmevaljob_pod(admin_client, lmevaljob_s3_offline)
+    yield get_lmevaljob_pod(client=admin_client, lmevaljob=lmevaljob_s3_offline)

tests/model_explainability/lm_eval/utils.py

@@ -30,20 +30,20 @@ def verify_lmevaljob_running(client: DynamicClient, lmevaljob: LMEvalJob) -> Non
     check_pod_status_in_time(pod=lmevaljob_pod, status={lmevaljob_pod.Status.RUNNING, lmevaljob_pod.Status.SUCCEEDED})
 
 
-def get_lmevaljob_pod(admin_client: DynamicClient, lmevaljob: LMEvalJob, timeout: int = Timeout.TIMEOUT_2MIN) -> Pod:
+def get_lmevaljob_pod(client: DynamicClient, lmevaljob: LMEvalJob, timeout: int = Timeout.TIMEOUT_2MIN) -> Pod:
     """
     Gets the pod corresponding to a given LMEvalJob and waits for it to be ready.
 
     Args:
-        admin_client: The Kubernetes client to use
+        client: The Kubernetes client to use
         lmevaljob: The LMEvalJob that the pod is associated with
         timeout: How long to wait for the pod, defaults to TIMEOUT_2MIN
 
     Returns:
         Pod resource
     """
     lmeval_pod = Pod(
-        client=admin_client,
+        client=client,
         namespace=lmevaljob.namespace,
         name=lmevaljob.name,
     )