Skip to content

Commit 3255289

Browse files
authored
Merge branch '2.25' into backport-operator-health-marker-2.25
2 parents 350a4dc + a32b874 commit 3255289

File tree

12 files changed

+792
-844
lines changed

12 files changed

+792
-844
lines changed

docs/GETTING_STARTED.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,6 @@ For example, to check only `Serveless` and `Service Mesh` operators, pass `--tc=
122122
To run tests with admin client only, pass `--tc=use_unprivileged_client:False` to pytest.
123123

124124

125-
### jira integration
126-
To skip running tests which have open bugs, [pytest_jira](https://github.com/rhevm-qe-automation/pytest_jira) plugin is used.
127-
To run tests with jira integration, you need to set `PYTEST_JIRA_URL` and `PYTEST_JIRA_TOKEN` environment variables.
128-
To make a test with jira marker, add: `@pytest.mark.jira(jira_id="RHOAIENG-0000", run=False)` to the test.
129-
130125

131126
### Running containerized tests
132127
Save kubeconfig file to a local directory, for example: `$HOME/kubeconfig`

pyproject.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ dependencies = [
5757
"grpcio-reflection",
5858
"portforward>=0.7.1",
5959
"pytest-testconfig>=0.2.0",
60-
"pytest-jira>=0.3.21",
6160
"pygithub>=2.5.0",
6261
"timeout-sampler>=1.0.6",
6362
"shortuuid>=1.0.13",
@@ -66,7 +65,6 @@ dependencies = [
6665
"semver>=3.0.4",
6766
"sqlalchemy>=2.0.40",
6867
"pytest-order>=1.3.0",
69-
"marshmallow==3.26.1,<4", # this version is needed for pytest-jira
7068
"pytest-html>=4.1.1",
7169
"fire",
7270
"llama_stack_client==0.2.23",

pytest.ini

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ testpaths = tests
55
markers =
66
# General
77
polarion: Store polarion test ID
8-
jira: Store jira bug ID
98
skip_on_disconnected: Mark tests that can only be run in deployments with Internet access i.e. not on disconnected clusters.
109

1110
# CI
@@ -59,4 +58,3 @@ addopts =
5958
--show-progress
6059
--tc-file=tests/global_config.py
6160
--tc-format=python
62-
--jira

tests/model_serving/model_runtime/triton/basic_model_deployment/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ def triton_serving_runtime(
157157
admin_client: DynamicClient,
158158
model_namespace: Namespace,
159159
protocol: str,
160-
supported_accelerator_type: str,
160+
supported_accelerator_type: str | None,
161161
) -> Generator[ServingRuntime, None, None]:
162162
template_name = get_template_name(protocol=protocol, accelerator_type=supported_accelerator_type)
163163
with ServingRuntimeFromTemplate(
@@ -178,7 +178,7 @@ def triton_inference_service(
178178
triton_serving_runtime: ServingRuntime,
179179
s3_models_storage_uri: str,
180180
triton_model_service_account: ServiceAccount,
181-
supported_accelerator_type: str,
181+
supported_accelerator_type: str | None,
182182
) -> Generator[InferenceService, Any, Any]:
183183
params = request.param
184184
model_format = params.get(

tests/model_serving/model_runtime/triton/basic_model_deployment/utils.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,15 +155,20 @@ def validate_inference_request(
155155
assert response == response_snapshot, f"Output mismatch: {response} != {response_snapshot}"
156156

157157

158-
def get_gpu_identifier(accelerator_type: str) -> str:
158+
def get_gpu_identifier(accelerator_type: str | None) -> str:
159+
if accelerator_type is None:
160+
return Labels.Nvidia.NVIDIA_COM_GPU
159161
return ACCELERATOR_IDENTIFIER.get(accelerator_type.lower(), Labels.Nvidia.NVIDIA_COM_GPU)
160162

161163

162-
def get_template_name(protocol: str, accelerator_type: str) -> str:
164+
def get_template_name(protocol: str, accelerator_type: str | None) -> str:
163165
"""
164166
Returns template name based on protocol and accelerator type.
165167
Falls back to default TRITON_REST if not found.
168+
If accelerator_type is None or empty, defaults to "nvidia".
166169
"""
170+
if not (accelerator_type and accelerator_type.strip()):
171+
accelerator_type = "nvidia"
167172
key = f"{protocol.lower()}_{accelerator_type.lower()}"
168173
return TEMPLATE_MAP.get(key, RuntimeTemplates.TRITON_REST)
169174

tests/model_serving/model_server/authentication/test_kserve_token_authentication_raw.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ def test_disabled_raw_model_authentication(self, patched_remove_raw_authenticati
5353
)
5454

5555
@pytest.mark.sanity
56-
@pytest.mark.jira("RHOAIENG-19275", run=False)
5756
def test_raw_disable_enable_authentication_no_pod_rollout(self, http_s3_caikit_raw_inference_service):
5857
"""Verify no pod rollout when disabling and enabling authentication"""
5958
pod = get_pods_by_isvc_label(

tests/model_serving/model_server/components/test_custom_resources.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ def wait_for_isvc_model_status(isvc: InferenceService, target_model_state: str,
3434
raise
3535

3636

37-
@pytest.mark.jira("RHOAIENG-10765")
3837
@pytest.mark.parametrize(
3938
"unprivileged_model_namespace, serving_runtime_from_template, invalid_s3_models_inference_service",
4039
[

tests/model_serving/model_server/model_car/test_oci_image.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
)
4444
class TestKserveModelCar:
4545
@pytest.mark.smoke
46-
@pytest.mark.jira("RHOAIENG-13465")
4746
def test_model_car_no_restarts(self, model_car_inference_service):
4847
"""Verify that model pod doesn't restart"""
4948
pod = get_pods_by_isvc_label(
@@ -57,7 +56,6 @@ def test_model_car_no_restarts(self, model_car_inference_service):
5756

5857
@pytest.mark.smoke
5958
@pytest.mark.ocp_interop
60-
@pytest.mark.jira("RHOAIENG-12306")
6159
def test_model_car_using_rest(self, model_car_inference_service):
6260
"""Verify model query with token using REST"""
6361
verify_inference_response(

tests/model_serving/model_server/ovms/kserve/test_onnx_serverless.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
)
3434
class TestONNXServerless:
3535
@pytest.mark.smoke
36-
@pytest.mark.jira("RHOAIENG-9045")
3736
def test_serverless_onnx_rest_inference(self, ovms_kserve_inference_service):
3837
"""Verify that kserve Serverless ONNX model can be queried using REST"""
3938
verify_inference_response(

tests/model_serving/model_server/raw_deployment/test_bge_large_eng_caikit.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
pytestmark = [pytest.mark.rawdeployment, pytest.mark.usefixtures("valid_aws_config")]
1515

1616

17-
@pytest.mark.jira("RHOAIENG-11749")
1817
@pytest.mark.parametrize(
1918
"unprivileged_model_namespace, serving_runtime_from_template, s3_models_inference_service",
2019
[

0 commit comments

Comments
 (0)