Skip to content

Commit 38cf6e8

Browse files
committed
fix: Increase llama-stack and vector_io related timeouts
Attempt to solve flaky tests failing due to timeouts Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
1 parent 0131b27 commit 38cf6e8

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

tests/fixtures/vector_io.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ def etcd_deployment(
8686
client=unprivileged_client,
8787
namespace=unprivileged_model_namespace.name,
8888
name="vector-io-etcd-deployment",
89+
min_ready_seconds=15,
8990
replicas=1,
9091
selector={"matchLabels": {"app": "etcd"}},
9192
strategy={"type": "Recreate"},
@@ -130,13 +131,14 @@ def remote_milvus_deployment(
130131
client=unprivileged_client,
131132
namespace=unprivileged_model_namespace.name,
132133
name="vector-io-milvus-deployment",
134+
min_ready_seconds=30,
133135
replicas=1,
134136
selector={"matchLabels": {"app": "milvus-standalone"}},
135137
strategy={"type": "Recreate"},
136138
template=get_milvus_deployment_template(),
137139
teardown=True,
138140
) as deployment:
139-
deployment.wait_for_replicas(deployed=True, timeout=Timeout.TIMEOUT_2MIN)
141+
deployment.wait_for_replicas(deployed=True, timeout=Timeout.TIMEOUT_4MIN)
140142
yield deployment
141143

142144

tests/llama_stack/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ def _get_llama_stack_distribution_deployment(
213213
client=client,
214214
namespace=llama_stack_distribution.namespace,
215215
name=llama_stack_distribution.name,
216+
min_ready_seconds=30,
216217
)
217218

218219
deployment.wait(timeout=Timeout.TIMEOUT_2MIN)
@@ -282,7 +283,7 @@ def _create_llama_stack_client(
282283
namespace=llama_stack_distribution_deployment.namespace,
283284
from_port=8321,
284285
to_port=8321,
285-
waiting=15,
286+
waiting=30,
286287
):
287288
client = LlamaStackClient(
288289
base_url="http://localhost:8321",

tests/llama_stack/utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,8 @@ def validate_api_responses(
351351

352352

353353
@retry(
354-
wait_timeout=Timeout.TIMEOUT_1MIN,
355-
sleep=5,
354+
wait_timeout=Timeout.TIMEOUT_2MIN,
355+
sleep=15,
356356
exceptions_dict={requests.exceptions.RequestException: [], Exception: []},
357357
)
358358
def vector_store_create_file_from_url(url: str, llama_stack_client: LlamaStackClient, vector_store: Any) -> bool:
@@ -369,7 +369,7 @@ def vector_store_create_file_from_url(url: str, llama_stack_client: LlamaStackCl
369369
bool: True if successful, raises exception if failed
370370
"""
371371
try:
372-
response = requests.get(url, timeout=30)
372+
response = requests.get(url, timeout=60)
373373
response.raise_for_status()
374374

375375
# Save file locally first and pretend it's a txt file, not sure why this is needed

0 commit comments

Comments
 (0)