Skip to content

Commit 431e66e

Browse files
committed
fix: typo and small refactor
Signed-off-by: lugi0 <[email protected]>
1 parent c35e61c commit 431e66e

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

tests/model_registry/python_client/test_model_registry_creation_oauth.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_registering_model_with_oauth(
5858
model_registry_client: ModelRegistryClient,
5959
):
6060
if py_config["distribution"] == "downstream" and get_product_version(admin_client=admin_client) < MINVER:
61-
pytest.skip("Skipping test for RHOAI < 2.21")
61+
pytest.skip(f"Skipping test for RHOAI < {MINVER}")
6262

6363
# Register a new model
6464
registered_model = model_registry_client.register_model(
@@ -91,14 +91,15 @@ def test_registering_model_with_oauth(
9191
pytest.fail("errors found in model registry response validation:\n{}".format("\n".join(errors)))
9292

9393
# Tests RHOAIENG-26195
94-
def test_encripted_oauth_proxy(
94+
def test_encrypted_oauth_proxy(
9595
self: Self,
9696
admin_client: DynamicClient,
9797
model_registry_instance_oauth_service: Service,
9898
current_client_token: str,
9999
):
100+
"""Test that connecting to encrypted OAuth proxy with HTTP protocol fails appropriately."""
100101
if py_config["distribution"] == "downstream" and get_product_version(admin_client=admin_client) < MINVER:
101-
pytest.skip("Skipping test for RHOAI < 2.21")
102+
pytest.skip(f"Skipping test for RHOAI < {MINVER}")
102103

103104
# Get the REST endpoint
104105
rest_endpoint = get_endpoint_from_mr_service(svc=model_registry_instance_oauth_service, protocol=Protocols.REST)

0 commit comments

Comments
 (0)