test(workbenches): update of the Notebook template removing auth container

The auth container (kube-rbac-proxy container) is injected by the
odh-notebook-controller anyway, so we can (and probably should) not keep
it as part of our template in the tests.

Author: jstourac

tests/workbenches/conftest.py

@@ -142,49 +142,6 @@ def default_notebook(
                             ],
                             "workingDir": "/opt/app-root/src",
                         },
-                        {
-                            "resources": {
-                                "limits": {"cpu": "100m", "memory": "64Mi"},
-                                "requests": {"cpu": "100m", "memory": "64Mi"},
-                            },
-                            "readinessProbe": {
-                                "failureThreshold": 3,
-                                "httpGet": {"path": "/healthz", "port": 8444, "scheme": "HTTPS"},
-                                "initialDelaySeconds": 5,
-                                "periodSeconds": 5,
-                                "successThreshold": 1,
-                                "timeoutSeconds": 1,
-                            },
-                            "name": "kube-rbac-proxy",
-                            "livenessProbe": {
-                                "failureThreshold": 3,
-                                "httpGet": {"path": "/healthz", "port": 8444, "scheme": "HTTPS"},
-                                "initialDelaySeconds": 30,
-                                "periodSeconds": 5,
-                                "successThreshold": 1,
-                                "timeoutSeconds": 1,
-                            },
-                            "ports": [{"containerPort": 8443, "name": "kube-rbac-proxy", "protocol": "TCP"}],
-                            "imagePullPolicy": "Always",
-                            "volumeMounts": [
-                                {"mountPath": "/etc/kube-rbac-proxy", "name": "kube-rbac-proxy-config"},
-                                {"mountPath": "/etc/tls/private", "name": "kube-rbac-proxy-tls-certificates"},
-                            ],
-                            "image": "quay.io/rhoai/odh-kube-auth-proxy-rhel9:rhoai-3.0",
-                            "args": [
-                                "--secure-listen-address=0.0.0.0:8443",
-                                "--upstream=http://127.0.0.1:8888/",
-                                "--logtostderr=true",
-                                "--v=10",
-                                "--proxy-endpoints-port=8444",
-                                "--config-file=/etc/kube-rbac-proxy/config-file.yaml",
-                                "--tls-cert-file=/etc/tls/private/tls.crt",
-                                "--tls-private-key-file=/etc/tls/private/tls.key",
-                                "--auth-header-fields-enabled=true",
-                                "--auth-header-user-field-name=X-Auth-Request-User",
-                                "--auth-header-groups-field-name=X-Auth-Request-Groups",
-                            ],
-                        },
                     ],
                     "enableServiceLinks": False,
                     "serviceAccountName": name,