[Mino] refactor minio and add model server minio tests (#206)

* Create size-labeler.yml

* Delete .github/workflows/size-labeler.yml

* model mesh - add auth tests

* xx

* feat: add gcs tests

* feat: refactor minio

* feat: refactor minio

* feat: refactor minio

* feat: add minio tests

* fix: update readme

* fix: TestGuardrails deploy

* fix: add json file

* ci: resolve conflicts

* fix: fixture names

* fix: fixture names

* fix: update fixtre name

Author: rnetser

docs/GETTING_STARTED.md

@@ -66,3 +66,12 @@ To run on ODH, pass `--tc=distribution:upstream` to pytest.
 To skip running tests which have open bugs, [pytest_jira](https://github.com/rhevm-qe-automation/pytest_jira) plugin is used.
 To run tests with jira integration, you need to set `PYTEST_JIRA_URL` and `PYTEST_JIRA_TOKEN` environment variables.
 To make a test with jira marker, add: `@pytest.mark.jira(jira_id="RHOAIENG-0000", run=False)` to the test.
+
+
+### Running containerized tests
+Save kubeconfig file to a local directory, for example: `$HOME/kubeconfig`
+To run tests in containerized environment:
+
+```bash
+podman run  -v $HOME:/mnt/host:Z  -e KUBECONFIG=/mnt/host/kubeconfig quay.io/opendatahub/opendatahub-tests
+```

pytest.ini

@@ -20,6 +20,7 @@ markers =
     modelmesh: Mark tests which are model mesh tests
     serverless: Mark tests which are serverless tests
     rawdeployment: Mark tests which are raw deployment tests
+    minio: Mark tests which are using MinIO storage
 
 addopts =
     -s

tests/conftest.py

@@ -6,10 +6,13 @@
 from typing import Any, Generator
 
 import pytest
+import shortuuid
 import yaml
 from _pytest.tmpdir import TempPathFactory
 from ocp_resources.config_map import ConfigMap
+from ocp_resources.pod import Pod
 from ocp_resources.secret import Secret
+from ocp_resources.service import Service
 from pyhelper_utils.shell import run_command
 from pytest import FixtureRequest, Config
 from kubernetes.dynamic import DynamicClient
@@ -21,14 +24,22 @@
 from simple_logger.logger import get_logger
 
 from utilities.data_science_cluster_utils import update_components_in_dsc
+from utilities.general import get_s3_secret_dict
 from utilities.infra import (
     create_ns,
     get_dsci_applications_namespace,
     get_operator_distribution,
     login_with_user_password,
     get_openshift_token,
 )
-from utilities.constants import AcceleratorType, DscComponents
+from utilities.constants import (
+    AcceleratorType,
+    ApiGroups,
+    DscComponents,
+    Labels,
+    MinIo,
+    Protocols,
+)
 from utilities.infra import update_configmap_data
 
 
@@ -285,7 +296,9 @@ def updated_dsc_component_state(
 
 
 @pytest.fixture(scope="package")
-def enabled_modelmesh_in_dsc(dsc_resource: DataScienceCluster) -> Generator[DataScienceCluster, Any, Any]:
+def enabled_modelmesh_in_dsc(
+    dsc_resource: DataScienceCluster,
+) -> Generator[DataScienceCluster, Any, Any]:
     with update_components_in_dsc(
         dsc=dsc_resource,
         components={DscComponents.MODELMESHSERVING: DscComponents.ManagementState.MANAGED},
@@ -305,7 +318,9 @@ def enabled_kserve_in_dsc(
 
 
 @pytest.fixture(scope="session")
-def cluster_monitoring_config(admin_client: DynamicClient) -> Generator[ConfigMap, Any, Any]:
+def cluster_monitoring_config(
+    admin_client: DynamicClient,
+) -> Generator[ConfigMap, Any, Any]:
     data = {"config.yaml": yaml.dump({"enableUserWorkload": True})}
 
     with update_configmap_data(
@@ -326,3 +341,104 @@ def unprivileged_model_namespace(
 
     with create_ns(unprivileged_client=unprivileged_client, pytest_request=request) as ns:
         yield ns
+
+
+# MinIo
+@pytest.fixture(scope="class")
+def minio_namespace(admin_client: DynamicClient) -> Generator[Namespace, Any, Any]:
+    with create_ns(
+        name=f"{MinIo.Metadata.NAME}-{shortuuid.uuid().lower()}",
+        admin_client=admin_client,
+    ) as ns:
+        yield ns
+
+
+@pytest.fixture(scope="class")
+def minio_pod(
+    request: FixtureRequest,
+    admin_client: DynamicClient,
+    minio_namespace: Namespace,
+) -> Generator[Pod, Any, Any]:
+    pod_labels = {Labels.Openshift.APP: MinIo.Metadata.NAME}
+
+    if labels := request.param.get("labels"):
+        pod_labels.update(labels)
+
+    with Pod(
+        client=admin_client,
+        name=MinIo.Metadata.NAME,
+        namespace=minio_namespace.name,
+        containers=[
+            {
+                "args": request.param.get("args"),
+                "env": [
+                    {
+                        "name": MinIo.Credentials.ACCESS_KEY_NAME,
+                        "value": MinIo.Credentials.ACCESS_KEY_VALUE,
+                    },
+                    {
+                        "name": MinIo.Credentials.SECRET_KEY_NAME,
+                        "value": MinIo.Credentials.SECRET_KEY_VALUE,
+                    },
+                ],
+                "image": request.param.get("image"),
+                "name": MinIo.Metadata.NAME,
+            }
+        ],
+        label=pod_labels,
+        annotations=request.param.get("annotations"),
+    ) as minio_pod:
+        yield minio_pod
+
+
+@pytest.fixture(scope="class")
+def minio_service(admin_client: DynamicClient, minio_namespace: Namespace) -> Generator[Service, Any, Any]:
+    with Service(
+        client=admin_client,
+        name=MinIo.Metadata.NAME,
+        namespace=minio_namespace.name,
+        ports=[
+            {
+                "name": f"{MinIo.Metadata.NAME}-client-port",
+                "port": MinIo.Metadata.DEFAULT_PORT,
+                "protocol": Protocols.TCP,
+                "targetPort": MinIo.Metadata.DEFAULT_PORT,
+            }
+        ],
+        selector={
+            Labels.Openshift.APP: MinIo.Metadata.NAME,
+        },
+    ) as minio_service:
+        yield minio_service
+
+
+@pytest.fixture(scope="class")
+def minio_data_connection(
+    request: FixtureRequest,
+    admin_client: DynamicClient,
+    model_namespace: Namespace,
+    minio_service: Service,
+) -> Generator[Secret, Any, Any]:
+    data_dict = get_s3_secret_dict(
+        aws_access_key=MinIo.Credentials.ACCESS_KEY_VALUE,
+        aws_secret_access_key=MinIo.Credentials.SECRET_KEY_VALUE,  # pragma: allowlist secret
+        aws_s3_bucket=request.param["bucket"],
+        aws_s3_endpoint=f"{Protocols.HTTP}://{minio_service.instance.spec.clusterIP}:{str(MinIo.Metadata.DEFAULT_PORT)}",  # noqa: E501
+        aws_s3_region="us-south",
+    )
+
+    with Secret(
+        client=admin_client,
+        name="aws-connection-minio-data-connection",
+        namespace=model_namespace.name,
+        data_dict=data_dict,
+        label={
+            Labels.OpenDataHub.DASHBOARD: "true",
+            Labels.OpenDataHubIo.MANAGED: "true",
+        },
+        annotations={
+            f"{ApiGroups.OPENDATAHUB_IO}/connection-type": "s3",
+            "openshift.io/display-name": "Minio Data Connection",
+        },
+    ) as minio_secret:
+        yield minio_secret