Skip to content

Commit 5279cc9

Browse files
authored
Renamed client instead of dyn_client in wrapper resource get calls (#981)
modified: tests/llama_stack/eval/conftest.py modified: tests/llama_stack/eval/utils.py modified: tests/model_explainability/guardrails/conftest.py modified: tests/model_explainability/trustyai_service/service/utils.py modified: tests/model_explainability/trustyai_service/trustyai_service_utils.py modified: tests/model_explainability/trustyai_service/utils.py modified: utilities/mariadb_utils.py
1 parent a1ebdcd commit 5279cc9

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

tests/llama_stack/eval/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def teardown_lmeval_job_pod(admin_client, model_namespace) -> None:
8989
if pods := [
9090
pod
9191
for pod in Pod.get(
92-
dyn_client=admin_client, namespace=model_namespace.name, label_selector="app.kubernetes.io/name=ta-lmes"
92+
client=admin_client, namespace=model_namespace.name, label_selector="app.kubernetes.io/name=ta-lmes"
9393
)
9494
]:
9595
for pod in pods:
@@ -198,7 +198,7 @@ def dspa_route(
198198
def _get_dspa_route() -> Route | None:
199199
routes = list(
200200
Route.get(
201-
dyn_client=admin_client,
201+
client=admin_client,
202202
namespace=model_namespace.name,
203203
name="ds-pipeline-dspa",
204204
)

tests/llama_stack/eval/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def wait_for_dspa_pods(admin_client: DynamicClient, namespace: str, dspa_name: s
4343
label_selector = f"dspa={dspa_name}"
4444

4545
def _all_dspa_pods_running() -> bool:
46-
pods = list(Pod.get(dyn_client=admin_client, namespace=namespace, label_selector=label_selector))
46+
pods = list(Pod.get(client=admin_client, namespace=namespace, label_selector=label_selector))
4747
if not pods:
4848
return False
4949
return all(pod.instance.status.phase == Pod.Status.RUNNING for pod in pods)

tests/model_explainability/guardrails/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ def _get_pods() -> List[Pod]:
405405
return [
406406
pod
407407
for pod in Pod.get(
408-
dyn_client=client,
408+
client=client,
409409
namespace=namespace,
410410
label_selector=label_selector,
411411
)
@@ -543,7 +543,7 @@ def otelcol_metrics_endpoint(admin_client: DynamicClient, model_namespace: Names
543543

544544
service = next(
545545
Service.get(
546-
dyn_client=admin_client,
546+
client=admin_client,
547547
namespace=model_namespace.name,
548548
label_selector="app.kubernetes.io/component=opentelemetry-collector",
549549
)

tests/model_explainability/trustyai_service/service/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
def wait_for_trustyai_db_migration_complete_log(client: DynamicClient, trustyai_service: TrustyAIService) -> bool:
1515
trustyai_pod = list(
1616
Pod.get(
17-
dyn_client=client,
17+
client=client,
1818
namespace=trustyai_service.namespace,
1919
label_selector=f"app.kubernetes.io/instance={trustyai_service.name}",
2020
)

tests/model_explainability/trustyai_service/trustyai_service_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ def _get_deployments() -> list[Deployment]:
363363
def _get_pods() -> list[Pod]:
364364
return list(
365365
Pod.get(
366-
dyn_client=client,
366+
client=client,
367367
namespace=isvc.namespace,
368368
label_selector=pod_label_selector,
369369
)

tests/model_explainability/trustyai_service/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def _get_mariadb_pods() -> list[Pod]:
4343
_pods = [
4444
_pod
4545
for _pod in Pod.get(
46-
dyn_client=client,
46+
client=client,
4747
namespace=mariadb.namespace,
4848
label_selector=f"app.kubernetes.io/instance={mariadb.name}",
4949
)
@@ -92,7 +92,7 @@ def validate_trustyai_service_db_conn_failure(
9292
UnexpectedFailureError: if the pod failure is different from the expected failure mode.
9393
9494
"""
95-
pods = list(Pod.get(dyn_client=client, namespace=namespace.name, label_selector=label_selector))
95+
pods = list(Pod.get(client=client, namespace=namespace.name, label_selector=label_selector))
9696
mariadb_conn_failure_regex = (
9797
r"^.+ERROR.+Could not connect to mariadb:.+ PKIX path validation failed: "
9898
r"java\.security\.cert\.CertPathValidatorException: signature check failed"

utilities/mariadb_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def _get_mariadb_pods() -> list[Pod]:
1313
_pods = [
1414
_pod
1515
for _pod in Pod.get(
16-
dyn_client=client,
16+
client=client,
1717
namespace=mariadb.namespace,
1818
label_selector=f"app.kubernetes.io/instance={mariadb.name}",
1919
)

0 commit comments

Comments
 (0)