fixing bug in ovms_kserve_inference_service function that was preventing isvcs from being created with 0 min-replicas

Signed-off-by: Brett Thompson <196701379+brettmthompson@users.noreply.github.com>

Author: brettmthompson

tests/model_serving/model_server/conftest.py

@@ -368,16 +368,18 @@ def ovms_kserve_inference_service(
     if env_vars := request.param.get("env-vars"):
         isvc_kwargs["model_env_variables"] = env_vars
 
-    if min_replicas := request.param.get("min-replicas"):
+    if (min_replicas := request.param.get("min-replicas")) is not None:
         isvc_kwargs["min_replicas"] = min_replicas
+        if min_replicas == 0:
+            isvc_kwargs["wait_for_predictor_pods"] = False
 
     if max_replicas := request.param.get("max-replicas"):
         isvc_kwargs["max_replicas"] = max_replicas
 
     if scale_metric := request.param.get("scale-metric"):
         isvc_kwargs["scale_metric"] = scale_metric
 
-    if scale_target := request.param.get("scale-target"):
+    if (scale_target := request.param.get("scale-target")) is not None:
         isvc_kwargs["scale_target"] = scale_target
 
     with create_isvc(**isvc_kwargs) as isvc:

tests/model_serving/model_server/serverless/test_zero_initial_scale.py

@@ -52,7 +52,7 @@ def test_no_serverless_replicas_created_for_zero_initial_scale(
             "serving.knative.dev/configurationGeneration=1",
             create_isvc_label_selector_str(
                 isvc=ovms_kserve_inference_service,
-                resource_type="depoyment",
+                resource_type="deployment",
                 runtime_name=ovms_kserve_serving_runtime.name,
             ),
         ]
@@ -69,7 +69,7 @@ def test_no_serverless_replicas_created_for_zero_initial_scale(
             )
 
         if deployments[0].instance.spec.replicas == 0:
-            deployments[0].wait_for_replicas()
+            deployments[0].wait_for_replicas(deployed=False)
             return
 
         raise DeploymentValidationError(