Skip to content

Commit 58af57e

Browse files
authored
Merge branch 'main' into dependabot/uv/pyopenssl-26.0.0
2 parents 8a43831 + 73cc4d5 commit 58af57e

70 files changed

Lines changed: 1358 additions & 225 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/scripts/pr_workflow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def verify_allowed_user(self) -> bool:
109109
# check if the user is a member of opendatahub-tests-contributors
110110
membership = team.get_team_membership(member=self.user_login)
111111
LOGGER.info(f"User {self.user_login} is a member of the test contributor team. {membership}")
112-
return True # noqa: TRY300
112+
return True
113113
except UnknownObjectException:
114114
LOGGER.error(f"User {self.user_login} is not allowed for this action. Exiting.")
115115
return False

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ repos:
3636
exclude: .*/__snapshots__/.*|.*-input\.json$|^semgrep\.yaml$
3737

3838
- repo: https://github.com/astral-sh/ruff-pre-commit
39-
rev: v0.15.5
39+
rev: v0.15.6
4040
hooks:
4141
- id: ruff
4242
- id: ruff-format
@@ -50,7 +50,7 @@ repos:
5050
# - id: renovate-config-validator
5151

5252
- repo: https://github.com/gitleaks/gitleaks
53-
rev: v8.30.0
53+
rev: v8.30.1
5454
hooks:
5555
- id: gitleaks
5656

Dockerfile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ ENV PATH="$PATH:$BIN_DIR"
1313

1414
# Install system dependencies using dnf
1515
RUN dnf update -y \
16-
&& dnf install -y python3 python3-pip ssh gnupg curl gpg wget vim httpd-tools rsync openssl openssl-devel\
16+
&& dnf install -y python3 python3-pip ssh gnupg curl gpg wget vim httpd-tools rsync openssl openssl-devel skopeo\
1717
&& dnf clean all \
1818
&& rm -rf /var/cache/dnf
1919

@@ -22,6 +22,10 @@ RUN curl -sSL "https://github.com/fullstorydev/grpcurl/releases/download/v1.9.2/
2222
&& tar xvf /tmp/grpcurl_1.2.tar.gz --no-same-owner \
2323
&& mv grpcurl /usr/bin/grpcurl
2424

25+
# Install cosign
26+
RUN curl -sSL "https://github.com/sigstore/cosign/releases/download/v2.4.2/cosign-linux-amd64" --output /usr/bin/cosign \
27+
&& chmod +x /usr/bin/cosign
28+
2529
RUN useradd -ms /bin/bash $USER
2630
USER $USER
2731
WORKDIR $HOME_DIR

OWNERS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@ approvers:
33
- fege
44
- jgarciao
55
- lugi0
6+
- mwaykole
67
reviewers:
78
- dbasunag
89
- fege
910
- jgarciao
1011
- lugi0
12+
- mwaykole

docs/GETTING_STARTED.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ To run tests with admin client only, pass `--tc=use_unprivileged_client:False` t
138138
### jira integration
139139

140140
To skip running tests which have open bugs, [pytest_jira](https://github.com/rhevm-qe-automation/pytest_jira) plugin is used.
141-
To run tests with jira integration, you need to set `PYTEST_JIRA_URL` and `PYTEST_JIRA_TOKEN` environment variables.
141+
To run tests with jira integration, you need to set `PYTEST_JIRA_URL`, `PYTEST_JIRA_USERNAME` and `PYTEST_JIRA_PASSWORD` environment variables.
142142
To make a test with jira marker, add: `@pytest.mark.jira(jira_id="RHOAIENG-0000", run=False)` to the test.
143143

144144
### Running containerized tests

tests/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def registry_pull_secret(pytestconfig: Config) -> list[str]:
167167
try:
168168
for secret in registry_pull_secret:
169169
base64.b64decode(s=secret, validate=True)
170-
return registry_pull_secret # noqa: TRY300
170+
return registry_pull_secret
171171
except binascii.Error:
172172
raise ValueError("Registry pull secret is not a valid base64 encoded string")
173173

@@ -253,7 +253,7 @@ def modelcar_yaml_config(pytestconfig: pytest.Config) -> dict[str, Any] | None:
253253
modelcar_yaml = yaml.safe_load(file)
254254
if not isinstance(modelcar_yaml, dict):
255255
raise ValueError("modelcar.yaml should contain a dictionary.") # noqa: TRY004
256-
return modelcar_yaml # noqa: TRY300
256+
return modelcar_yaml
257257
except yaml.YAMLError as e:
258258
raise ValueError(f"Error parsing modelcar.yaml: {e}") from e
259259

tests/llama_stack/safety/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def guardrails_orchestrator_ssl_cert(guardrails_orchestrator_route: Route):
4848
with open(filepath, "w") as f:
4949
f.write("\n".join(cert_lines))
5050

51-
return filepath # noqa: TRY300
51+
return filepath
5252

5353
except Exception as e: # noqa: BLE001
5454
raise RuntimeError(f"Could not get certificate from {hostname}: {e}")

tests/llama_stack/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def wait_for_llama_stack_client_ready(client: LlamaStackClient) -> bool:
9898
f"vector_stores:{len(vector_stores.data)} "
9999
f"files:{len(files.data)})"
100100
)
101-
return True # noqa: TRY300
101+
return True
102102

103103
except (APIConnectionError, InternalServerError) as error:
104104
LOGGER.debug(f"Llama Stack server not ready yet: {error}")

tests/model_registry/mcp_servers/config/test_invalid_yaml.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@
3737
)
3838
@pytest.mark.usefixtures("mcp_invalid_yaml_configmap_patch")
3939
class TestMCPServerInvalidYAML:
40-
"""RHOAIENG-51582: Tests for graceful handling of invalid YAML sources (TC-LOAD-007, TC-LOAD-008)."""
40+
"""
41+
Tests for graceful handling of invalid YAML sources (TC-LOAD-007, TC-LOAD-008)."""
4142

4243
def test_valid_servers_loaded_despite_invalid_source(
4344
self: Self,

tests/model_registry/mcp_servers/config/test_multi_source.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
@pytest.mark.usefixtures("mcp_multi_source_configmap_patch")
1515
class TestMCPServerMultiSource:
16-
"""RHOAIENG-51582: Tests for loading MCP servers from multiple YAML sources (TC-LOAD-002)."""
16+
"""Tests for loading MCP servers from multiple YAML sources (TC-LOAD-002)."""
1717

1818
def test_all_servers_from_multiple_sources_loaded(
1919
self: Self,

0 commit comments

Comments
 (0)