Skip to content

Commit 6785119

Browse files
committed
addressed review comments
1 parent d2de295 commit 6785119

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

tests/model_registry/model_catalog/conftest.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,17 @@ def randomly_picked_model_from_catalog_api_by_source(
180180
model_registry_rest_headers: dict[str, str],
181181
request: pytest.FixtureRequest,
182182
) -> tuple[dict[Any, Any], str, str]:
183-
"""Pick a random model from a specific catalog (function-scoped for test isolation)
183+
"""
184+
Pick a random model from a specific catalog if a model name is not provided. If model name is provided, verify
185+
that it exists and is associated with a given catalog and return the same.
184186
185187
Supports parameterized headers via 'header_type':
186188
- 'user_token': Uses user_token_for_api_calls (default for user-specific tests)
187189
- 'registry': Uses model_registry_rest_headers (for catalog/registry tests)
190+
- 'model_name': Name of the model
188191
189-
Accepts 'catalog_id' or 'source' (alias) to specify the catalog.
192+
Accepts 'catalog_id' or 'source' (alias) to specify the catalog. Accepts 'model_name' to specify the model to
193+
look for.
190194
"""
191195
param = getattr(request, "param", {})
192196
# Support both 'catalog_id' and 'source' for backward compatibility

tests/model_registry/model_catalog/test_model_artifact_search.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def test_search_artifacts_by_invalid_filter_query(
5050
):
5151
"""
5252
Tests the API's response to invalid filter queries syntax when searching artifacts.
53-
It verifies that an invalid filter query syntaxt raises the correct error.
53+
It verifies that an invalid filter query syntax raises the correct error.
5454
"""
5555
_, model_name, catalog_id = randomly_picked_model_from_catalog_api_by_source
5656

0 commit comments

Comments
 (0)