address comment 3

Signed-off-by: Milind Waykole <mwaykole@redhat.com>

Author: mwaykole

tests/model_serving/model_server/keda/utils.py

@@ -4,25 +4,24 @@
 from kubernetes.dynamic.exceptions import ResourceNotFoundError
 
 
-def get_isvc_keda_scaledobject(client: DynamicClient, isvc: InferenceService) -> list[ScaledObject]:
+def get_isvc_keda_scaledobject(client: DynamicClient, isvc: InferenceService) -> ScaledObject:
     """
-    Get KEDA ScaledObject resources associated with an InferenceService.
+    Get KEDA ScaledObject resource associated with an InferenceService.
 
     Args:
         client (DynamicClient): OCP Client to use.
         isvc (InferenceService): InferenceService object.
 
     Returns:
-        list[ScaledObject]: A list containing the ScaledObject
+        ScaledObject: The ScaledObject for the InferenceService
 
     Raises:
-        ResourceNotFoundError: if no ScaledObjects are found.
+        ResourceNotFoundError: if the ScaledObject is not found.
     """
     namespace = isvc.namespace
     scaled_object_name = isvc.name + "-predictor"
 
     try:
-        scaled_object = ScaledObject(client=client, name=scaled_object_name, namespace=namespace, ensure_exists=True)
-        return [scaled_object]
+        return ScaledObject(client=client, name=scaled_object_name, namespace=namespace, ensure_exists=True)
     except Exception as e:
         raise ResourceNotFoundError(f"{isvc.name} has no KEDA ScaledObjects: {e}")

tests/model_serving/model_server/utils.py

@@ -248,8 +248,7 @@ def verify_keda_scaledobject(
         expected_query: Expected query string
         expected_threshold: Expected threshold as string (e.g. "50.000000")
     """
-    scaled_objects = get_isvc_keda_scaledobject(client=client, isvc=isvc)
-    scaled_object = scaled_objects[0]
+    scaled_object = get_isvc_keda_scaledobject(client=client, isvc=isvc)
     trigger_meta = scaled_object.instance.spec.triggers[0].metadata
     trigger_type = scaled_object.instance.spec.triggers[0].type
     query = trigger_meta.get("query")