Skip to content

Commit 82970e2

Browse files
committed
fix: increase timeouts in LMEval tests and fixtures
1 parent 5dbfc8d commit 82970e2

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

tests/model_explainability/lm_eval/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ def lmeval_data_downloader_pod(
204204
restart_policy="Never",
205205
volumes=[{"name": "pvc-volume", "persistentVolumeClaim": {"claimName": "lmeval-data"}}],
206206
) as pod:
207-
pod.wait_for_status(status=Pod.Status.SUCCEEDED, timeout=Timeout.TIMEOUT_10MIN)
207+
pod.wait_for_status(status=Pod.Status.SUCCEEDED, timeout=Timeout.TIMEOUT_20MIN)
208208
yield pod
209209

210210

@@ -318,7 +318,7 @@ def lmeval_minio_deployment(
318318
label=minio_app_label,
319319
wait_for_resource=True,
320320
) as deployment:
321-
deployment.wait_for_replicas(timeout=Timeout.TIMEOUT_10MIN)
321+
deployment.wait_for_replicas(timeout=Timeout.TIMEOUT_20MIN)
322322
yield deployment
323323

324324

tests/model_explainability/lm_eval/test_lm_eval.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
)
1818
def test_lmeval_huggingface_model(admin_client, model_namespace, lmevaljob_hf_pod):
1919
"""Basic test that verifies that LMEval can run successfully pulling a model from HuggingFace."""
20-
lmevaljob_hf_pod.wait_for_status(status=lmevaljob_hf_pod.Status.SUCCEEDED, timeout=Timeout.TIMEOUT_10MIN)
20+
lmevaljob_hf_pod.wait_for_status(status=lmevaljob_hf_pod.Status.SUCCEEDED, timeout=Timeout.TIMEOUT_20MIN)
2121

2222

2323
@pytest.mark.parametrize(
@@ -90,7 +90,7 @@ def test_lmeval_local_offline_unitxt_tasks_flan_20newsgroups(
9090
def test_lmeval_vllm_emulator(admin_client, model_namespace, lmevaljob_vllm_emulator_pod):
9191
"""Basic test that verifies LMEval works with vLLM using a vLLM emulator for more efficient evaluation"""
9292
lmevaljob_vllm_emulator_pod.wait_for_status(
93-
status=lmevaljob_vllm_emulator_pod.Status.SUCCEEDED, timeout=Timeout.TIMEOUT_10MIN
93+
status=lmevaljob_vllm_emulator_pod.Status.SUCCEEDED, timeout=Timeout.TIMEOUT_20MIN
9494
)
9595

9696

@@ -111,5 +111,5 @@ def test_lmeval_s3_storage(
111111
):
112112
"""Test to verify that LMEval works with a model stored in a S3 bucket"""
113113
lmevaljob_s3_offline_pod.wait_for_status(
114-
status=lmevaljob_s3_offline_pod.Status.SUCCEEDED, timeout=Timeout.TIMEOUT_10MIN
114+
status=lmevaljob_s3_offline_pod.Status.SUCCEEDED, timeout=Timeout.TIMEOUT_20MIN
115115
)

tests/model_explainability/lm_eval/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def verify_lmevaljob_running(client: DynamicClient, lmevaljob: LMEvalJob) -> Non
2525
"""
2626

2727
lmevaljob_pod = Pod(client=client, name=lmevaljob.name, namespace=lmevaljob.namespace, wait_for_resource=True)
28-
lmevaljob_pod.wait_for_status(status=lmevaljob_pod.Status.RUNNING, timeout=Timeout.TIMEOUT_10MIN)
28+
lmevaljob_pod.wait_for_status(status=lmevaljob_pod.Status.RUNNING, timeout=Timeout.TIMEOUT_20MIN)
2929

3030
check_pod_status_in_time(pod=lmevaljob_pod, status={lmevaljob_pod.Status.RUNNING, lmevaljob_pod.Status.SUCCEEDED})
3131

utilities/constants.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ class Timeout:
196196
TIMEOUT_5MIN: int = 5 * TIMEOUT_1MIN
197197
TIMEOUT_10MIN: int = 10 * TIMEOUT_1MIN
198198
TIMEOUT_15MIN: int = 15 * TIMEOUT_1MIN
199+
TIMEOUT_20MIN: int = 20 * TIMEOUT_1MIN
199200

200201

201202
class Containers:

0 commit comments

Comments
 (0)