Skip to content

Commit 8d7e914

Browse files
committed
chore: align mlserver s3 and model-car test-cases
Signed-off-by: Snomaan6846 <syedali@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
1 parent 6cf3fe3 commit 8d7e914

15 files changed

Lines changed: 55 additions & 62 deletions

tests/model_serving/model_runtime/mlserver/conftest.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def mlserver_serving_runtime(
6060
name=ModelInferenceRuntime.MLSERVER_RUNTIME,
6161
namespace=model_namespace.name,
6262
template_name=RuntimeTemplates.MLSERVER,
63-
deployment_type=request.param["deployment_type"],
63+
deployment_type=request.param["deployment_mode"],
6464
runtime_image=mlserver_runtime_image,
6565
) as model_runtime:
6666
yield model_runtime
@@ -98,7 +98,7 @@ def mlserver_inference_service(
9898
"storage_uri": s3_models_storage_uri,
9999
"model_format": mlserver_serving_runtime.instance.spec.supportedModelFormats[0].name,
100100
"model_service_account": mlserver_model_service_account.name,
101-
"deployment_mode": params.get("deployment_type", KServeDeploymentType.RAW_DEPLOYMENT),
101+
"deployment_mode": params.get("deployment_mode", KServeDeploymentType.RAW_DEPLOYMENT),
102102
"external_route": params.get("enable_external_route", False),
103103
}
104104

@@ -170,7 +170,7 @@ def mlserver_model_car_inference_service(
170170
if not storage_uri:
171171
raise ValueError("storage-uri is required in params")
172172

173-
deployment_mode = params.get("deployment-mode", KServeDeploymentType.RAW_DEPLOYMENT)
173+
deployment_mode = params.get("deployment_mode", KServeDeploymentType.RAW_DEPLOYMENT)
174174
model_format = params.get("model-format")
175175
if not model_format:
176176
raise ValueError("model-format is required in params")

tests/model_serving/model_runtime/mlserver/constant.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ class OutputType:
1818

1919

2020
LOCALHOST_URL: str = "http://localhost"
21-
RAW_DEPLOYMENT_TYPE: str = "raw"
2221
MODEL_PATH_PREFIX: str = "mlserver/model_repository"
2322

2423
PREDICT_RESOURCES: dict[str, list[dict[str, str | dict[str, str]]] | dict[str, dict[str, str]]] = {
@@ -36,7 +35,7 @@ class OutputType:
3635
}
3736

3837
BASE_RAW_DEPLOYMENT_CONFIG: dict[str, Any] = {
39-
"deployment_type": KServeDeploymentType.RAW_DEPLOYMENT,
38+
"deployment_mode": KServeDeploymentType.RAW_DEPLOYMENT,
4039
"min-replicas": 1,
4140
"enable_external_route": False,
4241
}

tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[lightgbm-modelcar-raw-deployment].json renamed to tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[lightgbm-modelcar-RawDeployment].json

File renamed without changes.

tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[lightgbm-modelcar-raw-deployment_text_type].json renamed to tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[lightgbm-modelcar-RawDeployment_text_type].json

File renamed without changes.

tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[onnx-modelcar-raw-deployment].json renamed to tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[onnx-modelcar-RawDeployment].json

File renamed without changes.

tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[sklearn-modelcar-raw-deployment].json renamed to tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[sklearn-modelcar-RawDeployment].json

File renamed without changes.

tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[xgboost-modelcar-raw-deployment].json renamed to tests/model_serving/model_runtime/mlserver/model_car/__snapshots__/test_mlserver_model_car/TestMLServerModelCar.test_mlserver_model_car_inference[xgboost-modelcar-RawDeployment].json

File renamed without changes.

tests/model_serving/model_runtime/mlserver/basic_model_deployment/__init__.py renamed to tests/model_serving/model_runtime/mlserver/s3/__init__.py

File renamed without changes.

tests/model_serving/model_runtime/mlserver/basic_model_deployment/__snapshots__/test_mlserver_basic_model_deployment/TestMLServerModels.test_mlserver_model_inference[lightgbm-raw-deployment].json renamed to tests/model_serving/model_runtime/mlserver/s3/__snapshots__/test_mlserver_s3/TestMLServerModels.test_mlserver_model_inference[lightgbm-s3-RawDeployment].json

File renamed without changes.

tests/model_serving/model_runtime/mlserver/basic_model_deployment/__snapshots__/test_mlserver_basic_model_deployment/TestMLServerModels.test_mlserver_model_inference[onnx-raw-deployment].json renamed to tests/model_serving/model_runtime/mlserver/s3/__snapshots__/test_mlserver_s3/TestMLServerModels.test_mlserver_model_inference[onnx-s3-RawDeployment].json

File renamed without changes.

0 commit comments

Comments
 (0)