Skip to content

Commit 9281698

Browse files
committed
implementing review feedback.
Signed-off-by: Kamesh Akella <kakella@redhat.com>
1 parent 0538f32 commit 9281698

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

AGENTS.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,10 @@ tests/ # Test modules by component
3838
├── <component>/ # Component test directories
3939
│ ├── conftest.py # Component-scoped fixtures
4040
│ └── test_*.py # Test files
41+
| └── utils.py # Component-specific utility functions
4142
utilities/ # Shared utility functions
4243
├── manifests/ # Runtime manifests and configs
43-
└── <topic>_utils.py # Topic-specific utilities
44+
└── <topic>_utils.py # Topic-specific utility functions
4445
```
4546

4647
## Essential Patterns

CONSTITUTION.md

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,19 @@ All changes MUST follow existing code patterns and architecture.
2323
- Use pre-commit hooks to enforce style (ruff, mypy, flake8)
2424
- Use absolute import paths; import specific functions rather than modules
2525
- Use descriptive names; meaningful names are better than short names
26-
- Add type annotations to all new code; mypy strict mode is enforced
26+
- Add type annotations to all new code; follow the rules defined in [pyproject.toml](./pyproject.toml)
2727

2828
**Rationale**: Consistent patterns reduce the learning curve and prevent architectural drift.
2929

30-
### III. Test Independence
30+
### III. Test Clarity and Dependencies
3131

32-
Each test MUST verify a single aspect of the product and SHOULD be independent of other tests.
32+
Each test MUST verify a single aspect of the product and may be dependent on other tests.
3333

3434
- Tests MUST have a clear purpose and be easy to understand
3535
- Tests MUST be properly documented with docstrings explaining what the test does
36-
- When test dependencies exist, use pytest-dependency plugin to declare them explicitly
36+
- When test dependencies exist, use pytest-dependency plugin to declare them explicitly, encourage use of dependency marker(s) when possible
3737
- Group related tests in classes only when they share fixtures; never group unrelated tests
3838

39-
**Rationale**: Independent tests enable parallel execution, easier debugging, and selective test runs.
40-
4139
### IV. Fixture Discipline
4240

4341
Fixtures MUST do one thing only and follow proper scoping.
@@ -50,7 +48,7 @@ Fixtures MUST do one thing only and follow proper scoping.
5048

5149
**Rationale**: Single-responsibility fixtures are easier to debug, reuse, and compose.
5250

53-
### V. Kubernetes API First
51+
### V. Interacting with Kubernetes Resources
5452

5553
All cluster interactions MUST use openshift-python-wrapper or oc CLI.
5654

@@ -143,13 +141,10 @@ This constitution supersedes all other practices when there is a conflict. All P
143141
1. Propose changes via PR to `CONSTITUTION.md`
144142
2. Changes require review by at least two maintainers
145143
3. Breaking changes (principle removal/redefinition) require team discussion
146-
4. All amendments MUST update version and date
147144

148145
### Versioning Policy
149146

150-
- MAJOR: Backward-incompatible governance/principle removals or redefinitions
151-
- MINOR: New principle/section added or materially expanded guidance
152-
- PATCH: Clarifications, wording, typo fixes, non-semantic refinements
147+
No versioning policy is enforced.
153148

154149
### Compliance Review
155150

0 commit comments

Comments
 (0)