Skip to content

Commit a5317cf

Browse files
authored
[model server] Concurrency rollout - Increase timeout waiting for running pods for slower clusters (#234)
* Create size-labeler.yml * Delete .github/workflows/size-labeler.yml * model mesh - add auth tests * xx * fix: increase pod timeout
1 parent 07a4fff commit a5317cf

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

tests/model_serving/model_server/serverless/test_concurrency_auto_scale.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ def test_auto_scale_using_concurrency(
5353
for pods in inference_service_pods_sampler(
5454
client=admin_client,
5555
isvc=s3_models_inference_service,
56-
timeout=Timeout.TIMEOUT_1MIN,
56+
timeout=Timeout.TIMEOUT_2MIN,
57+
sleep=10,
5758
):
5859
if pods:
5960
if len(pods) > 1 and all([pod.status == pod.Status.RUNNING for pod in pods]):
@@ -66,6 +67,7 @@ def test_pods_scaled_down_when_no_requests(self, admin_client, s3_models_inferen
6667
client=admin_client,
6768
isvc=s3_models_inference_service,
6869
timeout=Timeout.TIMEOUT_4MIN,
70+
sleep=10,
6971
):
7072
if pods and len(pods) == 1:
7173
return

tests/model_serving/model_server/serverless/utils.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,22 +139,25 @@ def verify_canary_traffic(
139139
)
140140

141141

142-
def inference_service_pods_sampler(client: DynamicClient, isvc: InferenceService, timeout: int) -> TimeoutSampler:
142+
def inference_service_pods_sampler(
143+
client: DynamicClient, isvc: InferenceService, timeout: int, sleep: int = 1
144+
) -> TimeoutSampler:
143145
"""
144146
Returns TimeoutSampler for inference service.
145147
146148
Args:
147149
client (DynamicClient): DynamicClient object
148150
isvc (InferenceService): InferenceService object
149151
timeout (int): Timeout in seconds
152+
sleep (int): Sleep time in seconds
150153
151154
Returns:
152155
TimeoutSampler: TimeoutSampler object
153156
154157
"""
155158
return TimeoutSampler(
156159
wait_timeout=timeout,
157-
sleep=1,
160+
sleep=sleep,
158161
func=get_pods_by_isvc_label,
159162
client=client,
160163
isvc=isvc,

0 commit comments

Comments
 (0)