fix: address comments

Author: rnetser

tests/model_serving/model_server/inference_service_configuration/conftest.py

@@ -32,6 +32,11 @@ def removed_isvc_env_vars(
         ):
             yield ovms_kserve_inference_service
 
+    else:
+        raise ValueError(
+            f"Inference service {ovms_kserve_inference_service.name} does not have env vars in predictor spec model."
+        )
+
 
 @pytest.fixture
 def isvc_pods(

utilities/infra.py

@@ -115,13 +115,22 @@ def wait_for_replicas_in_deployment(deployment: Deployment, replicas: int) -> No
         TimeoutExpiredError: If replicas are not updated in spec.
 
     """
-    for sample in TimeoutSampler(
-        wait_timeout=Timeout.TIMEOUT_2MIN,
-        sleep=1,
-        func=lambda: deployment.instance,
-    ):
-        if sample and sample.spec.replicas == replicas:
-            return
+    _replicas: int | None = None
+
+    try:
+        for sample in TimeoutSampler(
+            wait_timeout=Timeout.TIMEOUT_2MIN,
+            sleep=5,
+            func=lambda: deployment.instance,
+        ):
+            if sample and (_replicas := sample.spec.replicas) == replicas:
+                return
+
+    except TimeoutExpiredError:
+        LOGGER.error(
+            f"Replicas are not updated in spec.replicas for deployment {deployment.name}.Current replicas: {_replicas}"
+        )
+        raise
 
 
 def wait_for_inference_deployment_replicas(