Fix with new kserve version moving from RawDeployment namee to standard (#1283)

* Fix with new kserve version  moving from RawDeployment namee to standard

Signed-off-by: Milind waykole <mwaykole@redhat.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Milind waykole <mwaykole@redhat.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: mwaykole

tests/model_serving/model_server/utils.py

@@ -88,7 +88,7 @@ def verify_inference_response(
 
         elif (
             isinstance(inference_service, InferenceGraph)
-            and inference.deployment_mode == KServeDeploymentType.RAW_DEPLOYMENT
+            and inference.deployment_mode in KServeDeploymentType.RAW_DEPLOYMENT_MODES
         ):
             assert "x-forbidden-reason: Access to the InferenceGraph is not allowed" in res["output"]
 

utilities/constants.py

@@ -7,8 +7,11 @@
 class KServeDeploymentType:
     SERVERLESS: str = "Serverless"
     RAW_DEPLOYMENT: str = "RawDeployment"
+    STANDARD: str = "Standard"
     MODEL_MESH: str = "ModelMesh"
 
+    RAW_DEPLOYMENT_MODES: tuple[str, ...] = (RAW_DEPLOYMENT, STANDARD)
+
 
 class ModelFormat:
     CAIKIT: str = "caikit"

utilities/general.py

@@ -173,9 +173,9 @@ def create_isvc_label_selector_str(isvc: InferenceService, resource_type: str, r
 
     """
     deployment_mode = isvc.instance.metadata.annotations.get(Annotations.KserveIo.DEPLOYMENT_MODE)
-    if deployment_mode in (
-        KServeDeploymentType.SERVERLESS,
-        KServeDeploymentType.RAW_DEPLOYMENT,
+    if (
+        deployment_mode == KServeDeploymentType.SERVERLESS
+        or deployment_mode in KServeDeploymentType.RAW_DEPLOYMENT_MODES
     ):
         return f"{isvc.ApiGroup.SERVING_KSERVE_IO}/inferenceservice={isvc.name}"
 

utilities/inference_utils.py

@@ -118,7 +118,7 @@ def is_service_exposed(self) -> bool:
         """
         labels = self.inference_service.labels
 
-        if self.deployment_mode == KServeDeploymentType.RAW_DEPLOYMENT:
+        if self.deployment_mode in KServeDeploymentType.RAW_DEPLOYMENT_MODES:
             if isinstance(self.inference_service, InferenceGraph):
                 # For InferenceGraph, the logic is similar as in Serverless. Only the label is different.
                 return not (labels and labels.get(Labels.Kserve.NETWORKING_KSERVE_IO) == "cluster-local")
@@ -310,7 +310,7 @@ def generate_command(
 
         elif self.protocol == "grpc":
             cmd_exec = "grpcurl -connect-timeout 10 "
-            if self.deployment_mode == KServeDeploymentType.RAW_DEPLOYMENT:
+            if self.deployment_mode in KServeDeploymentType.RAW_DEPLOYMENT_MODES:
                 cmd_exec += " --plaintext "
 
         else:
@@ -536,10 +536,9 @@ def get_target_port(self, svc: Service) -> int:
                 and port.protocol.lower() == svc_protocol.lower()
                 and port.name == self.protocol
             ) or (
-                self.deployment_mode
-                in (
-                    KServeDeploymentType.RAW_DEPLOYMENT,
-                    KServeDeploymentType.SERVERLESS,
+                (
+                    self.deployment_mode in KServeDeploymentType.RAW_DEPLOYMENT_MODES
+                    or self.deployment_mode == KServeDeploymentType.SERVERLESS
                 )
                 and port.protocol.lower() == svc_protocol.lower()
             ):
@@ -679,15 +678,18 @@ def create_isvc(
         _annotations = {Annotations.KserveIo.DEPLOYMENT_MODE: deployment_mode}
 
     # model mesh auth is set in ServingRuntime
-    if enable_auth and deployment_mode in {KServeDeploymentType.SERVERLESS, KServeDeploymentType.RAW_DEPLOYMENT}:
+    if enable_auth and (
+        deployment_mode == KServeDeploymentType.SERVERLESS
+        or deployment_mode in KServeDeploymentType.RAW_DEPLOYMENT_MODES
+    ):
         _annotations[Annotations.KserveAuth.SECURITY] = "true"
 
     # default to True if deployment_mode is Serverless (default behavior of Serverless) if was not provided by the user
     # model mesh external route is set in ServingRuntime
     if external_route is None and deployment_mode == KServeDeploymentType.SERVERLESS:
         external_route = True
 
-    if external_route and deployment_mode == KServeDeploymentType.RAW_DEPLOYMENT:
+    if external_route and deployment_mode in KServeDeploymentType.RAW_DEPLOYMENT_MODES:
         labels[Labels.Kserve.NETWORKING_KSERVE_IO] = Labels.Kserve.EXPOSED
 
     if deployment_mode == KServeDeploymentType.SERVERLESS and external_route is False:

utilities/infra.py

@@ -272,7 +272,7 @@ def wait_for_inference_deployment_replicas(
             # to be set in deployment spec by HPA
             if (
                 isvc.instance.metadata.annotations.get("serving.kserve.io/deploymentMode")
-                == KServeDeploymentType.RAW_DEPLOYMENT
+                in KServeDeploymentType.RAW_DEPLOYMENT_MODES
             ):
                 wait_for_replicas_in_deployment(
                     deployment=deployment,