add image validation for model catalog (#625)

* feat: add image validation for model catalog

Signed-off-by: lugi0 <lgiorgi@redhat.com>

* fix: remove logging

Signed-off-by: lugi0 <lgiorgi@redhat.com>

---------

Signed-off-by: lugi0 <lgiorgi@redhat.com>

Author: lugi0

tests/model_registry/image_validation/test_verify_rhoai_images.py

@@ -7,6 +7,7 @@
     validate_container_images,
 )
 from ocp_resources.pod import Pod
+from tests.model_registry.utils import get_model_catalog_pod
 
 LOGGER = get_logger(name=__name__)
 
@@ -33,10 +34,14 @@ def test_verify_model_registry_images(
         admin_client: DynamicClient,
         model_registry_operator_pod: Pod,
         model_registry_instance_pod_by_label: Pod,
+        model_registry_namespace: str,
         related_images_refs: Set[str],
     ):
+        model_catalog_pod = get_model_catalog_pod(
+            client=admin_client, model_registry_namespace=model_registry_namespace
+        )[0]
         validation_errors = []
-        for pod in [model_registry_operator_pod, model_registry_instance_pod_by_label]:
+        for pod in [model_registry_operator_pod, model_registry_instance_pod_by_label, model_catalog_pod]:
             validation_errors.extend(
                 validate_container_images(
                     pod=pod, valid_image_refs=related_images_refs, skip_patterns=["openshift-service-mesh"]

utilities/general.py

@@ -196,7 +196,10 @@ def get_pod_images(pod: Pod) -> List[str]:
     Returns:
         List of container image strings
     """
-    return [container.image for container in pod.instance.spec.containers]
+    containers = [container.image for container in pod.instance.spec.containers]
+    if pod.instance.spec.initContainers:
+        containers.extend([init.image for init in pod.instance.spec.initContainers])
+    return containers
 
 
 def validate_image_format(image: str) -> Tuple[bool, str]: