Skip to content

Commit b861f3a

Browse files
committed
fix: fix minor nits suggestedy by llm
Signed-off-by: Jorge Garcia Oncins <jgarciao@redhat.com>
1 parent cfebe1b commit b861f3a

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

tests/llama_stack/conftest.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import os
21
from collections.abc import Callable, Generator
32
from typing import Any
43

@@ -22,6 +21,7 @@
2221
HTTPS_PROXY,
2322
IS_DISCONNECTED_CLUSTER,
2423
LLAMA_STACK_DISTRIBUTION_SECRET_DATA,
24+
LLS_CLIENT_VERIFY_SSL,
2525
LLS_CORE_EMBEDDING_MODEL,
2626
LLS_CORE_EMBEDDING_PROVIDER_MODEL_ID,
2727
LLS_CORE_INFERENCE_MODEL,
@@ -248,7 +248,7 @@ def test_with_remote_milvus(llama_stack_server_config):
248248
env_vars.extend(env_vars_vector_io)
249249

250250
if IS_DISCONNECTED_CLUSTER and HTTPS_PROXY:
251-
LOGGER.info(f"Setting proxy and tlsconfig configuration (https_proxy:{HTTPS_PROXY}")
251+
LOGGER.info(f"Setting proxy and tlsconfig configuration (https_proxy:{HTTPS_PROXY})")
252252
env_vars.append({"name": "HTTPS_PROXY", "value": HTTPS_PROXY})
253253

254254
# The operator sets SSL_CERT_FILE automatically when tlsConfig.caBundle is
@@ -641,9 +641,7 @@ def llama_stack_test_route(
641641
def _create_llama_stack_client(
642642
route: Route,
643643
) -> Generator[LlamaStackClient, Any, Any]:
644-
# LLS_CLIENT_VERIFY_SSL is false by default to be able to test with Self-Signed certificates
645-
verifySSL = os.getenv("LLS_CLIENT_VERIFY_SSL", "false").lower() == "true"
646-
http_client = httpx.Client(verify=verifySSL, timeout=300)
644+
http_client = httpx.Client(verify=LLS_CLIENT_VERIFY_SSL, timeout=300)
647645
try:
648646
client = LlamaStackClient(
649647
base_url=f"https://{route.host}",

tests/llama_stack/constants.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ class ModelInfo(NamedTuple):
3030

3131
IS_DISCONNECTED_CLUSTER: bool = os.getenv("IS_DISCONNECTED_CLUSTER", "false").lower() == "true"
3232
HTTPS_PROXY = os.getenv("SQUID_HTTPS_PROXY", "")
33+
34+
# LLS_CLIENT_VERIFY_SSL is false by default to be able to test with Self-Signed certificates
35+
LLS_CLIENT_VERIFY_SSL = os.getenv("LLS_CLIENT_VERIFY_SSL", "false").lower() == "true"
3336
LLS_CORE_POD_FILTER: str = "app=llama-stack"
3437
LLS_OPENSHIFT_MINIMAL_VERSION: VersionInfo = semver.VersionInfo.parse("4.17.0")
3538

0 commit comments

Comments
 (0)