Skip to content

Commit b943a2b

Browse files
authored
Post-upgrade validate storedversion (#491)
1 parent c321766 commit b943a2b

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

tests/model_registry/upgrade/test_model_registry_upgrade.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
import pytest
22
from typing import Self, Any
33

4+
from kubernetes.dynamic import DynamicClient
5+
46
from ocp_resources.pod import Pod
57
from tests.model_registry.constants import MODEL_NAME, MODEL_DICT
68
from model_registry.types import RegisteredModel
79
from model_registry import ModelRegistry as ModelRegistryClient
810
from ocp_resources.model_registry_modelregistry_opendatahub_io import ModelRegistry
11+
from ocp_resources.custom_resource_definition import CustomResourceDefinition
912
from simple_logger.logger import get_logger
1013
from tests.model_registry.rest_api.utils import ModelRegistryV1Alpha1
1114
from tests.model_registry.utils import (
@@ -26,7 +29,7 @@
2629
],
2730
indirect=True,
2831
)
29-
@pytest.mark.usefixtures("pre_upgrade_dsc_patch")
32+
@pytest.mark.usefixtures("pre_upgrade_dsc_patch", "model_registry_mysql_metadata_db", "model_registry_instance_mysql")
3033
class TestPreUpgradeModelRegistry:
3134
@pytest.mark.pre_upgrade
3235
def test_registering_model_pre_upgrade(
@@ -119,3 +122,16 @@ def test_model_registry_pod_log_mlmd_removal(
119122
validate_mlmd_removal_in_model_registry_pod_log(
120123
deployment_containers=model_registry_deployment_containers, pod_object=model_registry_pod
121124
)
125+
126+
@pytest.mark.post_upgrade
127+
def test_model_registry_storage_version(self, admin_client: DynamicClient):
128+
"""
129+
RHOAIENG-28213: Test to ensure v1beta1 is found in crd storedVersion
130+
Steps:
131+
After upgrade check if the storedVersion for CRD contains v1beta1
132+
"""
133+
mr_crd = CustomResourceDefinition(name="modelregistries.modelregistry.opendatahub.io")
134+
assert mr_crd.exists
135+
expected_stored_version = "v1beta1"
136+
stored_version = mr_crd.instance.status.storedVersions
137+
assert expected_stored_version in stored_version, f"Expected {expected_stored_version}, found: {stored_version}"

0 commit comments

Comments
 (0)