Feedback: Ruth

Author: israel-hdez

tests/model_serving/model_server/inference_graph/conftest.py

@@ -41,7 +41,7 @@ def dog_breed_inference_graph(
         namespace=model_namespace.name,
         nodes=nodes,
     ) as inference_graph:
-        inference_graph.wait_for_condition(inference_graph.Condition.READY, "True")
+        inference_graph.wait_for_condition(condition=inference_graph.Condition.READY, status="True")
         time.sleep(5)  # This wait helps OpenShift to fully enable the Route, if the InferenceGraph is exposed
         yield inference_graph
 

tests/model_serving/model_server/inference_graph/test_inference_graph_deployment.py

@@ -17,6 +17,7 @@ def test_inference_graph_deployment(self, dog_breed_inference_graph):
             inference_service=dog_breed_inference_graph,
             inference_config=ONNX_INFERENCE_CONFIG,
             inference_type=Inference.GRAPH,
+            model_name="dog-breed-classifier",
             protocol=Protocols.HTTPS,
             use_default_query=True,
         )

utilities/inference_utils.py

@@ -77,7 +77,8 @@ def get_deployment_type(self) -> str:
         if isinstance(self.inference_service, InferenceService):
             return self.inference_service.instance.status.deploymentMode
 
-        return KServeDeploymentType.SERVERLESS
+        if isinstance(self.inference_service, InferenceGraph):
+            return KServeDeploymentType.SERVERLESS
 
     def get_inference_url(self) -> str:
         """

utilities/manifests/onnx.py

@@ -19,7 +19,7 @@
             },
             "graph": {
                 "query_input": "@utilities/manifests/openvino/dog-input-tensor.json",
-                "query_output": r'{"model_name":"dog-breed-classifier","model_version":"1","outputs":\[{"name":"495","shape":\[1,133\],"datatype":"FP32","data":\[.*\]}\]}',
+                "query_output": r'{"model_name":"$model_name","model_version":"1","outputs":\[{"name":"495","shape":\[1,133\],"datatype":"FP32","data":\[.*\]}\]}',
                 "use_regex": True
             }
         },