Skip to content

Commit d85c341

Browse files
authored
Merge branch 'main' into operator_fix
2 parents ea390ea + 301abb3 commit d85c341

File tree

2 files changed

+24
-12
lines changed

2 files changed

+24
-12
lines changed

conftest.py

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,15 @@
4242
LOGGER = logging.getLogger(name=__name__)
4343
BASIC_LOGGER = logging.getLogger(name="basic")
4444

45+
# Add support to mark tests that does not have specific marking already, with tier2 marker
46+
EXCLUDE_MARKERS_FROM_DEFAULT_TIER2: set[str] = {"smoke", "tier1", "tier2", "tier3", "pre_upgrade", "post_upgrade"}
47+
# To include a component for default marking please add the component path to this list
48+
DEFAULT_TIER2_MARKER_TEST_PATHS: tuple[str, ...] = (
49+
"tests/model_registry",
50+
"tests/model_explainability",
51+
"tests/model_serving/maas_billing",
52+
)
53+
4554

4655
def pytest_addoption(parser: Parser) -> None:
4756
aws_group = parser.getgroup(name="AWS")
@@ -286,6 +295,19 @@ def _add_upgrade_test(_item: Item, _upgrade_deployment_modes: list[str]) -> bool
286295
items[:] = non_upgrade_tests
287296
config.hook.pytest_deselected(items=upgrade_tests)
288297

298+
_add_default_tier2_marker(items=items)
299+
300+
301+
def _add_default_tier2_marker(items: list[Item]) -> None:
302+
"""Add tier2 marker to tests that lack any tier/smoke/upgrade marker, for specific components."""
303+
for item in items:
304+
if not any(item.nodeid.startswith(path) for path in DEFAULT_TIER2_MARKER_TEST_PATHS):
305+
continue
306+
307+
item_markers = {mark.name for mark in item.iter_markers()}
308+
if not item_markers & EXCLUDE_MARKERS_FROM_DEFAULT_TIER2:
309+
item.add_marker(marker=pytest.mark.tier2)
310+
289311

290312
def pytest_sessionstart(session: Session) -> None:
291313
log_file = session.config.getoption(name="log_file") or "pytest-tests.log"

tests/model_registry/model_registry/rest_api/test_model_registry_rest_api.py

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,18 @@
4242
{},
4343
{},
4444
MODEL_REGISTER_DATA,
45-
marks=(pytest.mark.tier1),
45+
marks=pytest.mark.tier1,
4646
),
4747
pytest.param(
4848
{"db_name": "postgres"},
4949
{"db_name": "postgres"},
5050
MODEL_REGISTER_DATA,
51-
marks=(pytest.mark.tier2),
51+
marks=pytest.mark.smoke,
5252
),
5353
pytest.param(
5454
{"db_name": "default"},
5555
{"db_name": "default"},
5656
MODEL_REGISTER_DATA,
57-
marks=(pytest.mark.tier2),
5857
),
5958
pytest.param(
6059
{"db_name": "mariadb"},
@@ -84,7 +83,6 @@ class TestModelRegistryCreationRest:
8483
pytest.param(
8584
MODEL_REGISTER,
8685
"register_model",
87-
marks=pytest.mark.smoke,
8886
id="test_validate_registered_model",
8987
),
9088
pytest.param(
@@ -111,7 +109,6 @@ def test_validate_model_registry_resource(
111109
resource_name=data_key,
112110
)
113111

114-
@pytest.mark.tier2
115112
@pytest.mark.parametrize(
116113
"kind, resource_name",
117114
[
@@ -160,7 +157,6 @@ def test_default_postgres_db_resource_exists(
160157
for field in ["controller", "blockOwnerDeletion"]:
161158
assert owner_reference[0][field] is True
162159

163-
@pytest.mark.tier2
164160
def test_default_postgres_db_pod_log(
165161
self: Self,
166162
skip_if_not_default_db: None,
@@ -180,7 +176,6 @@ def test_default_postgres_db_pod_log(
180176
postgres_pod_log = pods[0].log(container="postgres")
181177
assert CONNECTION_STRING in postgres_pod_log
182178

183-
@pytest.mark.tier2
184179
def test_model_registry_validate_api_version(
185180
self: Self,
186181
admin_client: DynamicClient,
@@ -196,7 +191,6 @@ def test_model_registry_validate_api_version(
196191
expected_version = f"{ModelRegistry.ApiGroup.MODELREGISTRY_OPENDATAHUB_IO}/{ModelRegistry.ApiVersion.V1BETA1}"
197192
assert api_version == expected_version
198193

199-
@pytest.mark.tier2
200194
def test_model_registry_validate_kuberbacproxy_enabled(
201195
self: Self,
202196
model_registry_instance: list[ModelRegistry],
@@ -239,7 +233,6 @@ def test_model_registry_validate_kuberbacproxy_enabled(
239233
],
240234
indirect=["updated_model_registry_resource"],
241235
)
242-
@pytest.mark.tier2
243236
def test_create_update_model_artifact(
244237
self,
245238
updated_model_registry_resource: dict[str, Any],
@@ -284,7 +277,6 @@ def test_create_update_model_artifact(
284277
],
285278
indirect=["updated_model_registry_resource"],
286279
)
287-
@pytest.mark.tier2
288280
def test_updated_model_version(
289281
self,
290282
updated_model_registry_resource: dict[str, Any],
@@ -330,7 +322,6 @@ def test_updated_model_version(
330322
],
331323
indirect=["updated_model_registry_resource"],
332324
)
333-
@pytest.mark.tier2
334325
def test_updated_registered_model(
335326
self,
336327
updated_model_registry_resource: dict[str, Any],
@@ -375,7 +366,6 @@ class TestModelRegistryDeployment:
375366
Tests the complete deployment workflow from registered model to InferenceService.
376367
"""
377368

378-
@pytest.mark.tier2
379369
def test_registered_model_deployment(
380370
self,
381371
admin_client: DynamicClient,

0 commit comments

Comments
 (0)