Skip to content

Commit eeab453

Browse files
authored
Merge branch 'main' into enhance-vector-store-dataset
2 parents d83f060 + cfdb157 commit eeab453

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

tests/workbenches/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ workbenches/
1616

1717
### Current Test Suites
1818

19-
- **`test_imagestream_health.py`** - Validates that workbench ImageStreams are properly imported and resolved. Checks correct ImageStream counts, tag digest references (`@sha256:`), and `ImportSuccess` conditions for both notebook images (11 expected) and runtime images (7 expected)
19+
- **`test_imagestream_health.py`** - Validates that ImageStreams are properly imported and resolved. Uses compound label selectors (`opendatahub.io/notebook-image` or `opendatahub.io/runtime-image` combined with `platform.opendatahub.io/part-of`) to scope checks per component. Validates correct ImageStream counts, tag digest references (`@sha256:`), and `ImportSuccess` conditions for workbench notebook images (11 expected), workbench runtime images (7 expected), and trainer images (3 expected)
2020
- **`notebook-controller/test_spawning.py`** - Tests basic notebook creation via Notebook CR and validates pod creation. Also tests Auth proxy container resource customization via annotations
2121
- **`notebook-controller/test_custom_images.py`** - Validates custom workbench images contain required Python packages by spawning a workbench, installing any missing packages, and executing import verification
2222

tests/workbenches/test_imagestream_health.py

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,21 @@ def _validate_imagestreams_with_label(
176176
@pytest.mark.parametrize(
177177
"label_selector, expected_imagestream_count",
178178
[
179-
pytest.param("opendatahub.io/notebook-image=true", 11, id="notebook_imagestreams"),
180-
pytest.param("opendatahub.io/runtime-image=true", 7, id="runtime_imagestreams"),
179+
pytest.param(
180+
"opendatahub.io/notebook-image=true,platform.opendatahub.io/part-of=workbenches",
181+
11,
182+
id="notebook_imagestreams",
183+
),
184+
pytest.param(
185+
"opendatahub.io/runtime-image=true,platform.opendatahub.io/part-of=workbenches",
186+
7,
187+
id="runtime_imagestreams",
188+
),
189+
pytest.param(
190+
"opendatahub.io/notebook-image=true,platform.opendatahub.io/part-of=trainer",
191+
3,
192+
id="trainer_imagestreams",
193+
),
181194
],
182195
)
183196
def test_workbench_imagestreams_health(

0 commit comments

Comments
 (0)