Skip to content

Commit efc342d

Browse files
committed
address coderabit review comments
Signed-off-by: Swati Mukund Bagal <sbagal@redhat.com>
1 parent 000e0e5 commit efc342d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tests/model_serving/maas_billing/maas_subscription/test_api_key_crud.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def test_create_api_key(
5050
assert key.startswith("sk-oai-"), f"Expected 'sk-oai-' prefix, got: {key[:20]}"
5151
assert len(key) > len("sk-oai-"), "Key body after prefix must not be empty"
5252

53-
LOGGER.info(f"[create] Created key id={body['id']}, prefix={key[:15]}...")
53+
LOGGER.info(f"[create] Created key id={body['id']}, key_prefix=sk-oai-***")
5454

5555
get_resp, get_body = get_api_key(
5656
request_session_http=request_session_http,

tests/model_serving/maas_billing/maas_subscription/utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from collections.abc import Generator, Sequence
55
from contextlib import contextmanager
66
from typing import Any
7-
from urllib.parse import urlparse
7+
from urllib.parse import quote, urlparse
88

99
import pytest
1010
import requests
@@ -229,7 +229,7 @@ def get_api_key(
229229
"""
230230
Fetch a single API key by ID via MaaS API (GET /v1/api-keys/{id}).
231231
"""
232-
url = f"{base_url}/v1/api-keys/{key_id}"
232+
url = f"{base_url}/v1/api-keys/{quote(key_id, safe='')}"
233233
response = request_session_http.get(
234234
url=url,
235235
headers={"Authorization": f"Bearer {ocp_user_token}"},
@@ -292,7 +292,7 @@ def revoke_api_key(
292292
"""
293293
Revoke an API key via MaaS API (DELETE /v1/api-keys/{id}).
294294
"""
295-
url = f"{base_url}/v1/api-keys/{key_id}"
295+
url = f"{base_url}/v1/api-keys/{quote(key_id, safe='')}"
296296
response = request_session_http.delete(
297297
url=url,
298298
headers={"Authorization": f"Bearer {ocp_user_token}"},

0 commit comments

Comments
 (0)