Skip to content

Commit f42ddab

Browse files
Fix test in sanity for Rawdeployment dsc check (#1180)
* Fix test in sanity for Rawdeployment dsc check Signed-off-by: Milind waykole <mwaykole@redhat.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix test in sanity for Rawdeployment dsc check Signed-off-by: Milind waykole <mwaykole@redhat.com> --------- Signed-off-by: Milind waykole <mwaykole@redhat.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 41e4488 commit f42ddab

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

tests/model_serving/model_server/kserve/components/kserve_dsc_deployment_mode/conftest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from tests.model_serving.model_server.kserve.components.kserve_dsc_deployment_mode.utils import (
1616
patch_dsc_default_deployment_mode,
1717
)
18-
from utilities.constants import ModelAndFormat
18+
from utilities.constants import Labels, ModelAndFormat
1919
from utilities.inference_utils import create_isvc
2020

2121

@@ -58,6 +58,7 @@ def ovms_inference_service(
5858
storage_key=ci_endpoint_s3_secret.name,
5959
model_format=ModelAndFormat.OPENVINO_IR,
6060
model_version=request.param["model-version"],
61+
labels={Labels.Kserve.NETWORKING_KSERVE_IO: Labels.Kserve.EXPOSED},
6162
wait_for_predictor_pods=False,
6263
) as isvc:
6364
yield isvc

tests/model_serving/model_server/kserve/components/kserve_dsc_deployment_mode/test_kserve_dsc_default_deployment_mode.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
}
2727

2828

29-
@pytest.mark.rawdeployment
3029
@pytest.mark.parametrize(
3130
"default_deployment_mode_in_dsc, unprivileged_model_namespace, ovms_kserve_serving_runtime, ovms_inference_service",
3231
[

tests/model_serving/model_server/kserve/components/kserve_dsc_deployment_mode/utils.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ def wait_for_default_deployment_mode_in_cm(config_map: ConfigMap, deployment_mod
2525
TimeoutExpiredError: If default deployment mode value is not set in configmap
2626
2727
"""
28-
LOGGER.info(
29-
f"Wait for {{request_default_deployment_mode}} deployment mode to be set in {config_map.name} configmap"
30-
)
28+
LOGGER.info(f"Wait for {deployment_mode} deployment mode to be set in {config_map.name} configmap")
3129
for sample in TimeoutSampler(
3230
wait_timeout=Timeout.TIMEOUT_5MIN,
3331
sleep=5,

0 commit comments

Comments
 (0)