Skip to content

Commit f662466

Browse files
committed
fix circular import issue
Signed-off-by: Kamesh Akella <kakella@redhat.com>
1 parent 18eb439 commit f662466

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

utilities/general.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import utilities.infra
1515
from utilities.constants import Annotations, KServeDeploymentType, MODELMESH_SERVING
1616
from utilities.exceptions import UnexpectedResourceCountError, ResourceValueMismatch
17-
from utilities.must_gather_collector import get_base_dir, get_must_gather_collector_dir
1817
from ocp_resources.resource import Resource
1918
from timeout_sampler import retry
2019
from timeout_sampler import TimeoutExpiredError, TimeoutSampler
@@ -472,6 +471,8 @@ def wait_for_pods_running(
472471

473472

474473
def collect_pod_information(pod: Pod) -> None:
474+
# Import here to avoid circular import (must_gather_collector -> infra -> general)
475+
from utilities.must_gather_collector import get_base_dir, get_must_gather_collector_dir
475476
try:
476477
base_dir_name = get_must_gather_collector_dir() or get_base_dir()
477478
LOGGER.info(f"Collecting pod information for {pod.name}: {base_dir_name}")

0 commit comments

Comments
 (0)