fix metrics test

mwaykole · mwaykole · commit fe9a90969174 · 2025-12-04T10:52:50.000+05:30
Signed-off-by: Milind Waykole &lt;mwaykole@redhat.com&gt;
diff --git a/tests/model_serving/model_server/metrics/test_model_metrics.py b/tests/model_serving/model_server/metrics/test_model_metrics.py
@@ -53,7 +53,7 @@ def test_model_metrics_num_success_requests(self, ovms_kserve_inference_service,
         )
         validate_metrics_field(
             prometheus=prometheus,
-            metrics_query="ovms_requests_success",
+            metrics_query=f"ovms_requests_success{{namespace='{ovms_kserve_inference_service.namespace}'}}",
             expected_value="1",
         )
 
@@ -73,7 +73,7 @@ def test_model_metrics_num_total_requests(self, ovms_kserve_inference_service, p
         )
         validate_metrics_field(
             prometheus=prometheus,
-            metrics_query="ovms_requests_success",
+            metrics_query=f"ovms_requests_success{{namespace='{ovms_kserve_inference_service.namespace}'}}",
             expected_value=str(total_runs + 1),
         )
 
diff --git a/tests/model_serving/model_server/metrics/test_non_admin_users.py b/tests/model_serving/model_server/metrics/test_non_admin_users.py
@@ -38,6 +38,6 @@ def test_non_admin_raw_metrics(
         )
         validate_metrics_field(
             prometheus=prometheus,
-            metrics_query="ovms_requests_success",
+            metrics_query=f"ovms_requests_success{{namespace='{unprivileged_ovms_raw_inference_service.namespace}'}}",
             expected_value=str(total_runs),
         )

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ def test_model_metrics_num_success_requests(self, ovms_kserve_inference_service,`
`53`	`53`	`)`
`54`	`54`	`validate_metrics_field(`
`55`	`55`	`prometheus=prometheus,`
`56`		`- metrics_query="ovms_requests_success",`
	`56`	`+ metrics_query=f"ovms_requests_success{{namespace='{ovms_kserve_inference_service.namespace}'}}",`
`57`	`57`	`expected_value="1",`
`58`	`58`	`)`
`59`	`59`
`@@ -73,7 +73,7 @@ def test_model_metrics_num_total_requests(self, ovms_kserve_inference_service, p`
`73`	`73`	`)`
`74`	`74`	`validate_metrics_field(`
`75`	`75`	`prometheus=prometheus,`
`76`		`- metrics_query="ovms_requests_success",`
	`76`	`+ metrics_query=f"ovms_requests_success{{namespace='{ovms_kserve_inference_service.namespace}'}}",`
`77`	`77`	`expected_value=str(total_runs + 1),`
`78`	`78`	`)`
`79`	`79`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,6 @@ def test_non_admin_raw_metrics(`
`38`	`38`	`)`
`39`	`39`	`validate_metrics_field(`
`40`	`40`	`prometheus=prometheus,`
`41`		`- metrics_query="ovms_requests_success",`
	`41`	`+ metrics_query=f"ovms_requests_success{{namespace='{unprivileged_ovms_raw_inference_service.namespace}'}}",`
`42`	`42`	`expected_value=str(total_runs),`
`43`	`43`	`)`