Skip to content

Remove GPU test from smoke#1021

Merged
mwaykole merged 3 commits intoopendatahub-io:mainfrom
mwaykole:gpu-skip
Jan 16, 2026
Merged

Remove GPU test from smoke#1021
mwaykole merged 3 commits intoopendatahub-io:mainfrom
mwaykole:gpu-skip

Conversation

@mwaykole
Copy link
Copy Markdown
Member

@mwaykole mwaykole commented Jan 15, 2026

The Model Serving GPU test should be run with appropriate markers since DevTestOps environments do not use GPUs for smoke.
We plan to remove it for now

Signed-off-by: Milind Waykole <mwaykole@redhat.com>
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/wip', '/verified', '/lgtm', '/hold', '/cherry-pick', '/build-push-pr-image'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

Removed pytest smoke test markers (@pytest.mark.smoke) from two GPU model car test methods in the test suite. No test logic or functionality was altered; only test labeling metadata was removed from the decorators.

Changes

Cohort / File(s) Summary
Smoke test marker removal
tests/model_serving/model_server/kserve/model_car/test_gpu_ovms.py
Removed @pytest.mark.smoke decorator from test_gpu_model_car_no_restarts and test_gpu_model_car_using_rest test methods

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove GPU test from smoke' accurately describes the main change: removal of @pytest.mark.smoke decorators from two GPU test methods.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@dbasunag dbasunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add why it is being removed?

@threcc
Copy link
Copy Markdown
Contributor

threcc commented Jan 16, 2026

/lgtm

@mwaykole mwaykole enabled auto-merge (squash) January 16, 2026 10:33
@mwaykole mwaykole merged commit 7fd9561 into opendatahub-io:main Jan 16, 2026
8 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

mwaykole added a commit to mwaykole/opendatahub-tests that referenced this pull request Jan 23, 2026
Signed-off-by: Milind Waykole <mwaykole@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants