Skip to content

vLLM CPU x86 smoke tests#1030

Merged
dbasunag merged 5 commits intoopendatahub-io:mainfrom
edwardquarm:vllm-cpu-smoke-test
Jan 19, 2026
Merged

vLLM CPU x86 smoke tests#1030
dbasunag merged 5 commits intoopendatahub-io:mainfrom
edwardquarm:vllm-cpu-smoke-test

Conversation

@edwardquarm
Copy link
Copy Markdown
Contributor

@edwardquarm edwardquarm commented Jan 16, 2026

Description

jira: https://issues.redhat.com/browse/RHOAIENG-43474
Support running vLLM CPU x86 validation against model car container as part of RHOAI 3.3 vLLM CPU Tech preview epic.

The vLLM CPU template has been merged into rhds and will be available in rhoai-3.3.

How Has This Been Tested?

uv run pytest -vv tests/model_serving/model_runtime/model_validation/test_modelvalidation.py \
  --model_car_yaml_path=./tests/model_serving/model_runtime/model_validation/sample_modelcar_config.yaml \
  --vllm-runtime-image=quay.io/rh-ee-equarmjn/vllm-cpu \
  --supported-accelerator-type=CPU_x86 \
  --registry-host=registry.redhat.io \
  --snapshot-update

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • New Features
    • Added support for x86 CPU accelerator type, enabling model serving on x86-based CPU systems.
    • Extended runtime templates to include VLLM support for x86 CPU architecture.
    • Updated accelerator type mappings to support new x86 CPU configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Edward Quarm <equarmjnr@gmail.com>
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/build-push-pr-image', '/wip', '/lgtm', '/hold', '/verified', '/cherry-pick'}

Signed-off-by: Edward Quarm <equarmjnr@gmail.com>
Signed-off-by: Edward Quarm <equarmjnr@gmail.com>
Signed-off-by: Edward Quarm <equarmjnr@gmail.com>
@edwardquarm edwardquarm marked this pull request as ready for review January 17, 2026 04:41
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

The pull request adds support for a new CPU x86 accelerator type by introducing VLLM_CPU_x86 runtime template, CPU_x86 accelerator identifier, and corresponding label definitions in core constants, plus configuration mappings in test validation files.

Changes

Cohort / File(s) Summary
Core Constants
utilities/constants.py
Added VLLM_CPU_x86 to RuntimeTemplates; introduced CPU_x86 to AcceleratorType and updated SUPPORTED_LISTS to include it; created nested CPU class under Labels with CPU_x86 label constant
Test Validation Mappings
tests/model_serving/model_runtime/model_validation/constant.py
Added CPU_x86 entry to ACCELERATOR_IDENTIFIER mapping to Labels.CPU.CPU_x86 and corresponding entry in TEMPLATE_MAP pointing to RuntimeTemplates.VLLM_CPU_x86

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'vLLM CPU x86 smoke tests' directly relates to the PR's main objective of adding support for running vLLM CPU x86 validation tests. It clearly summarizes the primary change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@brettmthompson brettmthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dbasunag dbasunag merged commit b8c8870 into opendatahub-io:main Jan 19, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

mwaykole pushed a commit to mwaykole/opendatahub-tests that referenced this pull request Jan 23, 2026
* vLLM CPU x86 smoke tests

Signed-off-by: Edward Quarm <equarmjnr@gmail.com>

* vLLM CPU x86 smoke tests

Signed-off-by: Edward Quarm <equarmjnr@gmail.com>

* acclerator type

Signed-off-by: Edward Quarm <equarmjnr@gmail.com>

* acclerator type

Signed-off-by: Edward Quarm <equarmjnr@gmail.com>

---------

Signed-off-by: Edward Quarm <equarmjnr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants