Skip to content

Fix multinode test for kserve to detect gpu#1151

Merged
mwaykole merged 2 commits intoopendatahub-io:mainfrom
mwaykole:gpufix
Feb 26, 2026
Merged

Fix multinode test for kserve to detect gpu#1151
mwaykole merged 2 commits intoopendatahub-io:mainfrom
mwaykole:gpufix

Conversation

@mwaykole
Copy link
Copy Markdown
Member

@mwaykole mwaykole commented Feb 26, 2026

Pull Request

Summary

Related Issues

  • Fixes:
  • JIRA:

How it has been tested

  • Locally
  • Jenkins

Additional Requirements

  • If this PR introduces a new test image, did you create a PR to mirror it in disconnected environment?
  • If this PR introduces new marker(s)/adds a new component, was relevant ticket created to update relevant Jenkins job?

Summary by CodeRabbit

  • Tests
    • Updated test infrastructure for GPU node detection to use an improved label access pattern.

Signed-off-by: Milind waykole <mwaykole@redhat.com>
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/wip', '/hold', '/verified', '/cherry-pick', '/lgtm', '/build-push-pr-image'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 26, 2026

📝 Walkthrough

Walkthrough

A test fixture in the KServe multi-node configuration now uses explicit .keys() method when checking for GPU node labels instead of relying on implicit dictionary membership testing.

Changes

Cohort / File(s) Summary
Test Fixture Update
tests/model_serving/model_server/kserve/multi_node/conftest.py
Modified nvidia_gpu_nodes fixture to check label presence using in node.labels.keys() instead of in node.labels, changing the dictionary access pattern for GPU node filtering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely empty with only the template structure present, containing no actual content about the changes, rationale, or testing performed. Fill in the Summary section with details about the GPU detection fix and which sections of 'How it has been tested' and 'Additional Requirements' that apply to this change.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix multinode test for kserve to detect gpu' directly relates to the changeset, which modifies GPU node detection in the KServe multinode test configuration by filtering nodes based on GPU labels.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@mwaykole mwaykole enabled auto-merge (squash) February 26, 2026 03:30
@mwaykole mwaykole disabled auto-merge February 26, 2026 03:31
@mwaykole mwaykole enabled auto-merge (squash) February 26, 2026 03:31
@mwaykole mwaykole changed the title Fix multinode test for kserve to detctet gpu Fix multinode test for kserve to detect gpu Feb 26, 2026
Copy link
Copy Markdown
Contributor

@fege fege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mwaykole mwaykole merged commit 2017513 into opendatahub-io:main Feb 26, 2026
10 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants