Skip to content

fix: update MaaS modelref CRD check and utils#1196

Merged
sheltoncyril merged 3 commits intoopendatahub-io:mainfrom
SB159:feature/maas-modelref-crd-fix
Mar 10, 2026
Merged

fix: update MaaS modelref CRD check and utils#1196
sheltoncyril merged 3 commits intoopendatahub-io:mainfrom
SB159:feature/maas-modelref-crd-fix

Conversation

@SB159
Copy link
Copy Markdown
Contributor

@SB159 SB159 commented Mar 10, 2026

Pull Request

Summary

Update MaaS CRD check to use maasmodelrefs instead of maasmodels

Related Issues

  • Fixes:
  • JIRA:

How it has been tested

  • Locally
  • Jenkins

Additional Requirements

  • If this PR introduces a new test image, did you create a PR to mirror it in disconnected environment?
  • If this PR introduces new marker(s)/adds a new component, was relevant ticket created to update relevant Jenkins job?

Summary by CodeRabbit

  • Tests
    • Updated test expectations to align with updated resource naming conventions in the MaaS subscription pod health validation.

@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/cherry-pick', '/wip', '/verified', '/build-push-pr-image', '/hold', '/lgtm'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a501d137-269f-4b5f-9cec-84c89c09c95c

📥 Commits

Reviewing files that changed from the base of the PR and between bfad94d and 3741a43.

📒 Files selected for processing (1)
  • tests/model_serving/model_server/maas_billing/maas_subscription/component_health/test_maas_controller_health.py

📝 Walkthrough

Walkthrough

Updated test expectations in MaaS controller health checks, changing CRD name from maasmodels to maasmodelrefs and updating the kind label from MaaSModel to MaaSModelRef across parametrized test cases.

Changes

Cohort / File(s) Summary
Test Updates
tests/model_serving/model_server/maas_billing/maas_subscription/component_health/test_maas_controller_health.py
Updated CRD name reference from maasmodels.{ApiGroups.MAAS_IO} to maasmodelrefs.{ApiGroups.MAAS_IO} and kind label from MaaSModel to MaaSModelRef in pod health parametrization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating MaaS modelref CRD check and utils, which directly aligns with the code changes updating CRD names from maasmodels to maasmodelrefs.
Description check ✅ Passed The description covers the Summary section with a clear explanation of the changes and includes the How it has been tested section. However, the Related Issues section is incomplete with no actual issues or tickets referenced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@sheltoncyril sheltoncyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sheltoncyril sheltoncyril enabled auto-merge (squash) March 10, 2026 17:36
@sheltoncyril sheltoncyril merged commit cdabbf3 into opendatahub-io:main Mar 10, 2026
9 checks passed
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants