Skip to content

fix: Remove closed jira references and jira references from doc string#1228

Merged
dbasunag merged 5 commits intoopendatahub-io:mainfrom
dbasunag:jira_ref_ms
Mar 17, 2026
Merged

fix: Remove closed jira references and jira references from doc string#1228
dbasunag merged 5 commits intoopendatahub-io:mainfrom
dbasunag:jira_ref_ms

Conversation

@dbasunag
Copy link
Copy Markdown
Collaborator

@dbasunag dbasunag commented Mar 16, 2026

Pull Request

Summary

Jira references in doc string interferes with pytest-jira plugin and causes fail/x-pass unnecessarily.
Closed jira references with pytest.mark.jira are not doing anything, so removed those as well

Related Issues

  • Fixes:
  • JIRA:

How it has been tested

  • Locally
  • Jenkins

Additional Requirements

  • If this PR introduces a new test image, did you create a PR to mirror it in disconnected environment?
  • If this PR introduces new marker(s)/adds a new component, was relevant ticket created to update relevant Jenkins job?

Summary by CodeRabbit

  • Tests
    • Removed obsolete issue-tracking markers from multiple test modules.
    • Converted several issue-specific skips into generic skips and reinstated some previously skipped tests.
    • Removed conditional test logic tied to external issue tracking so tests run consistently.
    • Cleaned up test docstring and header formatting.

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
@github-actions
Copy link
Copy Markdown

The following are automatically added/executed:

  • PR size label.
  • Run pre-commit
  • Run tox
  • Add PR author as the PR assignee
  • Build image based on the PR

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To Cherry-pick a merged PR /cherry-pick <target_branch_name> to the PR. If <target_branch_name> is valid,
    and the current PR is merged, a cherry-picked PR would be created and linked to the current PR.
  • To build and push image to quay, add /build-push-pr-image in a comment. This would create an image with tag
    pr-<pr_number> to quay repository. This image tag, however would be deleted on PR merge or close action.
Supported labels

{'/lgtm', '/build-push-pr-image', '/hold', '/wip', '/cherry-pick', '/verified'}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 16, 2026

📝 Walkthrough

Walkthrough

Removed Jira-related markers and docstring references across KServe tests; deleted a Jira-conditional KEDA metric-patching block and its imports. Most edits are metadata/docstring cleanup or replacing Jira markers with generic skips; one autoscaling test lost the conditional metric-injection branch.

Changes

Cohort / File(s) Summary
Autoscaling logic removal
tests/model_serving/model_server/kserve/autoscaling/keda/test_isvc_keda_scaling_cpu.py
Deleted Jira-conditional block that patched KEDA ScaledObject metrics and removed related imports (ResourceEditor, is_jira_open), simplifying test flow.
Ingress test markers
tests/model_serving/model_server/kserve/ingress/test_route_visibility.py
Removed Jira-specific pytest markers and some skips; converted Jira-gated decorators to generic skips or reinstated tests accordingly.
Docstring cleanup (negative tests)
tests/model_serving/model_server/kserve/negative/test_invalid_model_name.py, tests/model_serving/model_server/kserve/negative/test_malformed_json_payload.py, tests/model_serving/model_server/kserve/negative/test_missing_required_fields.py, tests/model_serving/model_server/kserve/negative/test_unsupported_content_type.py, tests/model_serving/model_server/kserve/negative/test_wrong_input_data_type.py
Removed Jira reference lines and adjusted docstring formatting; no behavioral changes.
Pytest marker adjustments
tests/model_serving/model_server/kserve/platform/test_custom_resources.py, tests/model_serving/model_server/kserve/storage/oci/test_oci_image.py
Removed @pytest.mark.jira(...) markers; in storage tests replaced some Jira marks with explicit @pytest.mark.skip(reason=...).
Cosmetic change
tests/model_serving/model_server/kserve/multi_node/conftest.py
Removed an inline comment from a ServingRuntimeFromTemplate call; no functional change.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed Title accurately describes the main change: removing closed Jira references and Jira docstring references across multiple test files.
Description check ✅ Passed Description provides clear rationale (pytest-jira plugin interference) but omits specific files modified and specific Jira tickets being removed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
@dbasunag dbasunag requested a review from mwaykole March 17, 2026 13:16
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
tests/model_serving/model_server/kserve/storage/oci/test_oci_image.py (1)

56-67: Unconditional skip lacks re-enablement tracking.

The @pytest.mark.skip decorator will prevent this test from ever running until manually removed. Consider using @pytest.mark.xfail with strict=False if the underlying issue is intermittent, or add a TODO/FIXME comment with acceptance criteria for when to un-skip.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@tests/model_serving/model_server/kserve/storage/oci/test_oci_image.py` around
lines 56 - 67, The test test_model_car_using_rest is unconditionally skipped via
`@pytest.mark.skip`, which prevents automatic re-enablement; replace the
unconditional skip with a non-strict xfail (e.g.,
`@pytest.mark.xfail`(strict=False, reason="RHOAIENG-12306")) or add a conditional
skip that checks an env flag so the test can be re-enabled automatically, and
add a TODO/FIXME comment above the test referencing RHOAIENG-12306 plus clear
acceptance criteria for when to remove the xfail/skip; update references to the
test function name test_model_car_using_rest and its fixture
model_car_inference_service so reviewers can find the changed decorator and
comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/model_serving/model_server/kserve/ingress/test_route_visibility.py`:
- Line 192: Replace the unconditional `@pytest.mark.skip` decorator applied to the
GRPC raw-route tests with either `@pytest.mark.xfail`(strict=False, reason="...
GH-<issue>") so the tests run and failures are visible, or with
`@pytest.mark.skipif`(<capability check>, reason="... GH-<issue>") so skipping is
conditional; update both occurrences (the class-level decorator currently set to
`@pytest.mark.skip`(reason="skipping grpc raw for tgis-caikit") around the grpc
raw-route tests) to include a short GitHub issue reference in the reason string
(e.g., "GH-12345") and, if using skipif, implement a clear capability predicate
(e.g., HAS_GRPC_RAW or a helper function) so CI sees regressions while still
allowing intentional skips.

---

Nitpick comments:
In `@tests/model_serving/model_server/kserve/storage/oci/test_oci_image.py`:
- Around line 56-67: The test test_model_car_using_rest is unconditionally
skipped via `@pytest.mark.skip`, which prevents automatic re-enablement; replace
the unconditional skip with a non-strict xfail (e.g.,
`@pytest.mark.xfail`(strict=False, reason="RHOAIENG-12306")) or add a conditional
skip that checks an env flag so the test can be re-enabled automatically, and
add a TODO/FIXME comment above the test referencing RHOAIENG-12306 plus clear
acceptance criteria for when to remove the xfail/skip; update references to the
test function name test_model_car_using_rest and its fixture
model_car_inference_service so reviewers can find the changed decorator and
comment.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ab7a4440-0d47-4350-b60f-453f3e53562b

📥 Commits

Reviewing files that changed from the base of the PR and between e52ad03 and eeead9b.

📒 Files selected for processing (2)
  • tests/model_serving/model_server/kserve/ingress/test_route_visibility.py
  • tests/model_serving/model_server/kserve/storage/oci/test_oci_image.py

Copy link
Copy Markdown
Contributor

@SB159 SB159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dbasunag dbasunag enabled auto-merge (squash) March 17, 2026 15:02
@dbasunag dbasunag merged commit 6237646 into opendatahub-io:main Mar 17, 2026
9 checks passed
@dbasunag dbasunag deleted the jira_ref_ms branch March 17, 2026 15:05
@github-actions
Copy link
Copy Markdown

Status of building tag latest: success.
Status of pushing tag latest to image registry: success.

ssaleem-rh pushed a commit to ssaleem-rh/opendatahub-tests that referenced this pull request Mar 23, 2026
opendatahub-io#1228)

* fix: Remove closed jira references and jira references from doc string

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>

* fix: add the skips based on review comments

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>

---------

Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
Signed-off-by: Shehan Saleem <ssaleem@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants